Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles sidebar: Comment pagination inner blocks have the same button text as Query pagination inner blocks #43907

Closed
carolinan opened this issue Sep 6, 2022 · 3 comments · Fixed by #44287
Assignees
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@carolinan
Copy link
Contributor

carolinan commented Sep 6, 2022

Description

In the global styles sidebar in the site editor, the inner blocks of the comment pagination and the query pagination have the same button text, so it is difficult to tell them apart.
For example, both the query pagination next and comment pagination next have the button text "Next Page".

Step-by-step reproduction instructions

  1. Activate a theme with support for the site editor
  2. Go to the site editor and open the styles sidebar. Select blocks.
  3. In the search field, enter "next". See that there is more than one block with the same button text.

Screenshots, screen recording, code snippet

The styles sidebar with a list of blocks that has the same button text

Environment info

WordPress 6.0.2
Gutenberg current trunk

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Sep 9, 2022
@annezazu
Copy link
Contributor

annezazu commented Sep 9, 2022

@ockham wanted to flag for you :) Would be great to get this quickly renamed/cleared up for the comments block.

@annezazu annezazu added the [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop label Sep 9, 2022
@ockham
Copy link
Contributor

ockham commented Sep 12, 2022

Thanks for flagging! Should be easy enough to rename 😄 Just to clarify, this is the block name, so it'll also change e.g. in the block inserter.

What should we call it?

Some ideas:

  • "Next Comments Page"
  • "Comments: Next Page"
  • "Comments Next Page" (no colon -- more consistent with "Comment Pagination", but kinda ugly IMO)

Do we have precedent for something like this? I.e. naming "subordinate" (inner) blocks for a parent block? 🤔

@annezazu
Copy link
Contributor

I'm not sure if we do! I'd recommend asking in Core Editor to see if anyone might have some insights there. I'm afraid I don't have capacity to dive in deeper this week.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 20, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants