Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove colon (:) from Video and Audio blocks placeholder text #4427

Closed
monika-12 opened this issue Jan 12, 2018 · 1 comment
Closed

Remove colon (:) from Video and Audio blocks placeholder text #4427

monika-12 opened this issue Jan 12, 2018 · 1 comment
Assignees
@Soean
Labels
[Feature] Blocks Overall functionality of blocks [Type] Copy Issues or PRs that need copy editing assistance [Type] Enhancement A suggestion for improvement.

Comments

@monika-12
Copy link

monika-12 commented Jan 12, 2018 •
edited
Loading

## Issue Overview
On video and audio blocks - there is colon after the text "Select a video file from your library:" remove this colon from text. There should be consistency with other block like Image, Gallery, Cover Image.

## Steps to Reproduce (for bugs)

  1. Insert Video Block
  2. Check colon after placeholder text
  3. Insert Other block like Image, gallery
  4. No colon after placeholder text

I am using Google Chrome on Windows 10.

## Expected Behavior
Placeholder Text ended without colon.

## Current Behavior
Placeholder Tex ended with colon.

## Possible Solution
Remove colon from placeholder text.

## Screenshots / Video
video-placeholder-text
audio-text
@monika-12 monika-12 changed the title Remove colon (:) from Video block placeholder text Remove colon (:) from Video and Audio block placeholder text Jan 12, 2018
@monika-12 monika-12 changed the title Remove colon (:) from Video and Audio block placeholder text Remove colon (:) from Video and Audio blocks placeholder text Jan 12, 2018
@Soean Soean self-assigned this Jan 12, 2018
@Soean Soean added [Type] Enhancement A suggestion for improvement. [Type] Copy Issues or PRs that need copy editing assistance [Feature] Blocks Overall functionality of blocks labels Jan 12, 2018
@Soean Soean mentioned this issue Jan 12, 2018
Merged
@Soean
Copy link
Member

Soean commented Jan 12, 2018

All media blocks:
media

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Soean Soean

Labels
[Feature] Blocks Overall functionality of blocks [Type] Copy Issues or PRs that need copy editing assistance [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Soean @monika-12