Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a modal when dropping a file outside the dropzone #44292

Open
javierarce opened this issue Sep 20, 2022 · 7 comments
Open

Show a modal when dropping a file outside the dropzone #44292

javierarce opened this issue Sep 20, 2022 · 7 comments
Labels
[Feature] Drag and Drop Drag and drop functionality when working with blocks [Feature] Media Anything that impacts the experience of managing media Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@javierarce
Copy link
Contributor

javierarce commented Sep 20, 2022

In this PR @mtias suggested showing a modal when a user drags a file to the editor but outside of the dropzone.

The text of the modal could indicate the type of the file the user is trying to add (image, video, etc.) or we could go with something more generic, like "media". Something else we could do is to show an error modal if the user drags an unrecognized file type.

image

image

Initial exploration

Here are a couple of ideas for such a modal: one with a simple list of text options and another one with images.

image

Screen.Recording.2022-09-20.at.12.15.47.mov

Figma file

@javierarce javierarce added Needs Design Feedback Needs general design feedback. [Feature] Drag and Drop Drag and drop functionality when working with blocks labels Sep 20, 2022
@jasmussen

This comment was marked as outdated.

@javierarce

This comment was marked as outdated.

@jasmussen

This comment was marked as outdated.

@jasmussen
Copy link
Contributor

@javierarce we can probably update the main ticket here with your latest iteration, then swap out the tags and send this over to a dev. What do you think?

@javierarce javierarce added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Sep 28, 2022
@javierarce
Copy link
Contributor Author

@jasmussen done. I ended up using an icon size of 48px… bigger than your last proposal but not so big as my initial one, but we can explore other styles as the feature gets implemented.

@jasmussen
Copy link
Contributor

Looks great!

@mtias mtias added the [Feature] Media Anything that impacts the experience of managing media label Oct 3, 2022
@apeatling
Copy link
Contributor

This would be a really nice UX win, would be great to get it in 6.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Drag and Drop Drag and drop functionality when working with blocks [Feature] Media Anything that impacts the experience of managing media Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants