Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WP 6.1] Fluid and spacing settings in theme.json are lost when theme export #44546

Closed
mayuge3 opened this issue Sep 28, 2022 · 8 comments · Fixed by #44555
Closed

[WP 6.1] Fluid and spacing settings in theme.json are lost when theme export #44546

mayuge3 opened this issue Sep 28, 2022 · 8 comments · Fixed by #44555
Assignees
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended

Comments

@mayuge3
Copy link

mayuge3 commented Sep 28, 2022

Description

When I use theme export,

  • settings.spacing.spacingScale.steps -> field is lost
  • settings.spacing.spacingSizes.slug -> quotation is lost
  • settings.typography.fluid -> field is lost

Step-by-step reproduction instructions

  1. Use WP 6.1 nightly and Twenty Twenty Three without gutenberg plugin
  2. Go to the site editor.
  3. Select Three dots menu > Export

Screenshots, screen recording, code snippet

spacing before export:
n1631

spacing after export:
n1632

fluid before export:
n1633

fluid after export:
n1634

Environment info

WP 6.1 (latest nightly via Beta Tester plugin), instawp install
TT3 included in WP 6.1 nightly.
Gutenberg plugin deactivated

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@glendaviesnz glendaviesnz self-assigned this Sep 28, 2022
@glendaviesnz glendaviesnz added [Type] Bug An existing feature does not function as intended [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Sep 28, 2022
@glendaviesnz glendaviesnz moved this from Triage to In Progress in WordPress 6.1 Editor Tasks Sep 28, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 29, 2022
@glendaviesnz
Copy link
Contributor

glendaviesnz commented Sep 29, 2022

I have a fix for the spacingScale value here, still trying to work out the fluid font value as it isn't related and only happens in 6.1, not GB trunk

@glendaviesnz
Copy link
Contributor

The fluid flag was a different issue and a potential fix for it is here

@ramonjd
Copy link
Member

ramonjd commented Sep 29, 2022

Thank you @mayuge3 Also reported in https://core.trac.wordpress.org/ticket/56684 Props to you!

@mayuge3
Copy link
Author

mayuge3 commented Sep 29, 2022

Thank you!

I'm not familiar with technical details, so I opened another issue #214 at TT3, is it related to this issue's fluid problem...?

@dream-encode
Copy link

I was looking to merge this, but I want to make sure this comment by @tellthemachines is addressed in the final PR:
#44555 (review)

@glendaviesnz
Copy link
Contributor

but I want to make sure this comment by @tellthemachines is addressed in the final PR

thanks @dream-encode, I will look at the issue with casting to ints on a separate PR as it will be a bit trickier to resolve and test.

@ndiego
Copy link
Member

ndiego commented Oct 10, 2022

@glendaviesnz I just wanted to confirm that this issue is all set, given the merged and closed PRs. I noticed the issue still had the Backport label, so I wanted to double check before I removed it. Thanks!

@glendaviesnz glendaviesnz removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Oct 11, 2022
@glendaviesnz
Copy link
Contributor

Thanks @ndiego, have removed the label now.

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants