Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wp-block-group__inner-container markup is missing on new default Group blocks #44636

Closed
jeremyfelt opened this issue Oct 3, 2022 · 1 comment · Fixed by #44660
Closed

wp-block-group__inner-container markup is missing on new default Group blocks #44636

jeremyfelt opened this issue Oct 3, 2022 · 1 comment · Fixed by #44660
Assignees
Labels
[Block] Group Affects the Group Block [Type] Bug An existing feature does not function as intended

Comments

@jeremyfelt
Copy link
Member

Description

In #42763 and #44176, the "constrained" layout was set as the default for the Group block and the default variation used when inserting a Group block into content was updated.

I believe the reasoning for this was to preserve existing "default" Group blocks—these have an inner container injected on the front-end in classic themes for backward compatibility—while also changing some other defaults about the Group block itself. (It's late and I didn't really parse everything, but #42763 is a very nicely documented PR!). 😄

This change doesn't immediately break backward compatibility in that existing groups remain as is and have the same markup on the front-end.

However, any new Group blocks inserted into content on an existing site have different markup and may now appear broken on the front-end, even though a person maintaining their site has used the same process for years.

If <!-- wp:group {"layout":{"type":"constrained"}} --> is the new "default" Group block, then it makes sense from a user experience perspective (IMO) to include it as one of those in which an inner container is injected in classic themes.

Step-by-step reproduction instructions

  1. On WordPress 6.0.2, add a new page, add a group block, view the markup: see an inner container.
  2. With Gutenberg 14.2 added, do the same: see no inner container.

Screenshots, screen recording, code snippet

No response

Environment info

  • WordPress 6.0.2
  • Gutenberg 14.2

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@jeremyfelt jeremyfelt added the [Block] Group Affects the Group Block label Oct 3, 2022
@Mamaduka
Copy link
Member

Mamaduka commented Oct 3, 2022

cc @tellthemachines, @youknowriad

@youknowriad youknowriad added the [Type] Bug An existing feature does not function as intended label Oct 3, 2022
@tellthemachines tellthemachines self-assigned this Oct 4, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 4, 2022
@glendaviesnz glendaviesnz moved this from Triage to In Progress in WordPress 6.1 Editor Tasks Oct 4, 2022
Repository owner moved this from In Progress to Done in WordPress 6.1 Editor Tasks Oct 5, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Group Affects the Group Block [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants