Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Margin visualizer incorrectly shows inwards #44693

Closed
jasmussen opened this issue Oct 5, 2022 · 2 comments · Fixed by #44718
Closed

Margin visualizer incorrectly shows inwards #44693

jasmussen opened this issue Oct 5, 2022 · 2 comments · Fixed by #44718
Assignees
Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@jasmussen
Copy link
Contributor

Extracting from #44484 (comment): there appears to be an issue with the margin visualization, where if you apply margin to, for example, a group block, the visualization resizes inwards as if to indicate padding, instead of outwards. GIF showing this:

bug

In an older iteration, this worked as intended:

before

It isn't clear when this regression happened. I've seen it work prior to #44323, but it isn't clear that PR introduce the regression either, please see additional context here.

@jasmussen jasmussen added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release labels Oct 5, 2022
@talldan
Copy link
Contributor

talldan commented Oct 5, 2022

It is a bug in 6.1 so I've added it to the project board. It's most noticeable for me when adjusting the margin on the group within TT3's header.

@glendaviesnz
Copy link
Contributor

This seems to be related to the clamp values that TT3 is using for spacing sizes, eg. clamp(7rem, 14vw, 11rem). If I replace these with simple rem values the margin visualiser works as expected. I will take a closer look and see if there is anyway of getting the clamp values into the format that the visualiser can cope with.

@glendaviesnz glendaviesnz self-assigned this Oct 5, 2022
@glendaviesnz glendaviesnz moved this from Triage to In Progress in WordPress 6.1 Editor Tasks Oct 5, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 5, 2022
Repository owner moved this from In Progress to Done in WordPress 6.1 Editor Tasks Oct 6, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants