Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn that customisations will be lost on style variation switch #45210

Closed
jameskoster opened this issue Oct 21, 2022 · 3 comments
Closed

Warn that customisations will be lost on style variation switch #45210

jameskoster opened this issue Oct 21, 2022 · 3 comments
Labels
[Feature] Theme Style Variations Related to style variations provided by block themes Needs Design Needs design efforts.

Comments

@jameskoster
Copy link
Contributor

Problem: When you switch away from a customised style variation it's not clear that those customisations will be lost. Technically you can undo yourself out of trouble, but if you save and exit the editor then that customised style variation is gone, without any warning.

Comprehensive style variation management is being explored in #38333, but that's a pretty big feature that will take time to implement. This is a problem now and a short term solution like a warning could help folks avoid losing their hard work.

@jasmussen
Copy link
Contributor

#45371 takes a different stab at this by clearly delineating customized styles as separate.

@jasmussen
Copy link
Contributor

What do you think of the latest iterations to #45371? By copying a style to "Custom styles" (and adding the unread dot) as soon as it gets customized, does it resolve this?

@jameskoster
Copy link
Contributor Author

Yes, I think so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Theme Style Variations Related to style variations provided by block themes Needs Design Needs design efforts.
Projects
None yet
Development

No branches or pull requests

2 participants