Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToggleGroupControl: Try to refactor as-button/as-radio #45356

Open
mirka opened this issue Oct 27, 2022 · 1 comment
Open

ToggleGroupControl: Try to refactor as-button/as-radio #45356

mirka opened this issue Oct 27, 2022 · 1 comment
Labels
[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality

Comments

@mirka
Copy link
Member

mirka commented Oct 27, 2022

As noted in #45123 (comment), there is some code redundancy in the as-button and as-radio subcomponents. It's worth looking into whether we can abstract it cleanly.
@mirka mirka added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels Oct 27, 2022
@mirka mirka mentioned this issue Oct 27, 2022
Merged
@t-hamano
Copy link
Contributor

I don't know if this is related to this issue, but I am happy to report that I have submitted #45381 regarding ToggleControl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mirka @t-hamano