Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components: Popover uses top and left positioning hurting scroll performance #45382

Closed
corentin-gautier opened this issue Oct 28, 2022 · 0 comments · Fixed by #46187
Closed

Components: Popover uses top and left positioning hurting scroll performance #45382

corentin-gautier opened this issue Oct 28, 2022 · 0 comments · Fixed by #46187
Assignees
@corentin-gautier
Labels
[Package] Components /packages/components [Type] Performance Related to performance efforts

Comments

@corentin-gautier
Copy link
Contributor

corentin-gautier commented Oct 28, 2022 •
edited
Loading

Using top and left positioning triggers a repaint of the area which could be avoided using transform : translate(x, y), improving performances (currently the scroll performances of the editor are not really good, even more when using fixed backgrounds)

gutenberg/packages/components/src/popover/index.tsx

Line 466 in df98b4b

left: Number.isNaN( x ) ? 0 : x ?? undefined,

Screen.Recording.2022-10-28.at.15.47.36.mov
@corentin-gautier corentin-gautier changed the title Popover component uses top and left positioning hurting scroll performance Components: Popover uses top and left positioning hurting scroll performance Oct 29, 2022
@talldan talldan added [Type] Performance Related to performance efforts [Package] Components /packages/components labels Oct 30, 2022
@corentin-gautier corentin-gautier mentioned this issue Nov 4, 2022
Closed
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 4, 2022
@corentin-gautier corentin-gautier mentioned this issue Nov 30, 2022
Merged
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corentin-gautier corentin-gautier

Labels
[Package] Components /packages/components [Type] Performance Related to performance efforts
Projects
None yet
Milestone
No milestone
3 participants
@talldan @corentin-gautier @priethor