-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation List View: Add a block appender #45445
Comments
FYI the end of this video has a small snippet where the expected UI is detailed Update: here's a screenshot |
@SaxonF I wonder could you confirm how you see this appender working? Is it always at the end of the list of items as per the prototypes? Or can it appear elsewhere? Any other detail, mockups or guidance at this point before we go too far would be much appreciated 🙇 |
@getdave let's start with always at the end but the "trigger" for the add menu item dialog should be able to appear anywhere so that we can play with its position easily in future. |
@ajlende Status update: I continued working on your PR to add the necessarily functionality but it started getting unwieldy pretty quickly. I spoken with @scruffian and decided to also explore a simpler approach using the standard inserter from the canvas. So we have x2 PRs that are variations on the same effort:
The basic problem is:
At this point both PRs need review and feedback. The next step is to break out the changes to the Offcanvas List View that diverge it from primary LV into a separate PR:
We can also invite design feedback and fix any items from code review. I was aiming to merge a simple PR that "just works" and then move on to address the other UX issues in follow ups. The most important is making the inserter popup appear in the sidebar not the canvas. |
As outlined in #42257 we need to add a block appender to the Navigation List View to allow users to add more items to their navigation:
This will probably require us fixing this issue at some point: #18295
The text was updated successfully, but these errors were encountered: