Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button block appender not working after update 6.1 #45506

Closed
ghost opened this issue Nov 3, 2022 · 5 comments
Closed

Button block appender not working after update 6.1 #45506

ghost opened this issue Nov 3, 2022 · 5 comments
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended

Comments

@ghost
Copy link

ghost commented Nov 3, 2022

Description

Hi,

I am experiencing an issue with the button block appender which I already stated here: #45497 and here https://core.trac.wordpress.org/ticket/56965.

Now I just did a fresh install of WordPress 6.1 with the Twenty Twenty-Three theme and this issue still seems to persist.

Therefor I'm creating this new bug report since I think this is an issue on its own (different from #45497).

Step-by-step reproduction instructions

  • Clean/fresh install of WordPress 6.1
  • Navigate to the site editor
  • Select a template to edit (in this example I clicked on the "single" template to edit)
  • Click on the "footer" template part
  • Add a "columns" block inside the "footer" template part (it seems this is essential to reproduce the problem, outside of a template part it seems to work fine)
  • Save your changes
  • Refresh the page
  • Scroll down to the block you just added (columns block)
  • Try to click on the button block appender which appears inside the "column block"
  • Nothing happens, can't add new blocks (seems like pointer-events:none; gets attached to the button block appender while it shouldn't?)

Screenshots, screen recording, code snippet

Scherm­afbeelding 2022-11-03 om 08 24 03
Scherm­afbeelding 2022-11-03 om 08 24 30

Environment info

  • Clean/fresh WordPress 6.1 install with default Twenty Twenty-Three theme (no Gutenberg plugin used)
  • All browsers
  • All devices

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu
Copy link
Contributor

annezazu commented Nov 3, 2022

Moving to the 6.1.1 board to be triaged.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Package] Blocks /packages/blocks [Package] Block editor /packages/block-editor labels Nov 4, 2022
@t-hamano
Copy link
Contributor

t-hamano commented Nov 4, 2022

I have confirmed that this problem is not reproduced in the latest Gutenberg.
And this problem seems to have been unintentionally resolved in PR #44865.

By comparing before and after this commit is applied, we should be able to see that this PR has solved the problem.

  • git checkout 705d783: Reproduced
  • git checkout d50e613: Not reproduced

gutenberg_45506

@youknowriad
Could you please advise if this PR should be backported to WP6.1?

@t-hamano t-hamano removed the [Package] Blocks /packages/blocks label Nov 4, 2022
@youknowriad
Copy link
Contributor

That PR is a bit impactful as it changes how useDisabled works. So our options are either:

  • Backport the PR and test properly (so far I didn't see any downsides to the PR)
  • Come up with a fix for the old implementation of useDisabled. (if that's even possible).

I'd suggest trying the second approach quickly first and if there's nothing obvious, backport that PR.

@Mamaduka Mamaduka moved this from Triage to Todo in WordPress 6.1.x Editor Tasks Nov 7, 2022
@t-hamano
Copy link
Contributor

t-hamano commented Nov 8, 2022

Thanks for the advice, @youknowriad.

Come up with a fix for the old implementation of useDisabled. (if that's even possible).

I found a comment related to this issue regarding some of the changes in #40631.

This is another addition in this PR. Basically any clickable item inside the disabled element is now "non clickable"

As this comment indicates, removing the changes in this area will resolve this issue. However, the useDisabled hook is very complicated for me and I can't decide if this is the right way to do it 😅

@Mamaduka Mamaduka moved this from Todo to Bumped to 6.2 in WordPress 6.1.x Editor Tasks Nov 14, 2022
@annezazu
Copy link
Contributor

annezazu commented Sep 6, 2024

Closing this out as the PR has since been backported into Core just by virtue of our release process in 6.2 per this tracking issue: #47187

@annezazu annezazu closed this as completed Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended
Projects
No open projects
Status: Bumped to 6.2
Development

No branches or pull requests

3 participants