Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backported code from WP 6.0 compat layer #45508

Closed
ockham opened this issue Nov 3, 2022 · 4 comments
Closed

Remove backported code from WP 6.0 compat layer #45508

ockham opened this issue Nov 3, 2022 · 4 comments
Labels
[Type] Code Quality Issues or PRs that relate to code quality

Comments

@ockham
Copy link
Contributor

ockham commented Nov 3, 2022

Now that WordPress 6.1 has been released, we should remove the back-compat code for WordPress 6.0 (in lib/compat/wordpress-6.0/) from Gutenberg. This is because Gutenberg supports the current and previous versions of WordPress (i.e 6.1 and 6.0); the code in lib/compat/wordpress-6.1/ is needed to allow it to work on a WP 6.0 installation (which lacks some code that is in 6.1). (OTOH, the lib/compat/wordpress-6.0/ dir is no longer needed, as it provides backwards compatibility for WP 5.9 and older; but those versions are no longer supported by Gutenberg.)

We should also look out for tests for that code in phpunit, make sure that those tests have been carried over to wordpress-develop (and add them there if they haven't), and remove them.

We might need to exercise a bit more care when removing code in lib/block-supports; I'm not entirely sure how that (unversioned) compat layer is applied to Gutenberg.

cc/ @c4rl0sbr4v0 @ramonjd @oandregal @scruffian in case y'all wanna help with this 😊

@ockham ockham added the [Type] Code Quality Issues or PRs that relate to code quality label Nov 3, 2022
@ramonjd
Copy link
Member

ramonjd commented Nov 3, 2022

cc/ @c4rl0sbr4v0 @ramonjd @oandregal @scruffian in case y'all wanna help with this

You bet. I started with typography a while back already: #43928 Need to dust it off.

Will be out of action next week, but I'll put this issue on a list to remind my brain.

@Mamaduka
Copy link
Member

Mamaduka commented Nov 6, 2022

We cannot remove code from the WP 6.1 compat layer, only from 6.0. The plugin still has to support WP 6.0.

@ockham
Copy link
Contributor Author

ockham commented Nov 30, 2022

We cannot remove code from the WP 6.1 compat layer, only from 6.0. The plugin still has to support WP 6.0.

Of course 🤦‍♂️ Thank you for pointing that out! I'll change the issue title and contents 😅

@ockham ockham changed the title Remove backported code from WP 6.1 compat layer Remove backported code from WP 6.0 compat layer Nov 30, 2022
@ockham
Copy link
Contributor Author

ockham commented Dec 12, 2022

Closed by #46102.

@ockham ockham closed this as completed Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

No branches or pull requests

3 participants