-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nav block use slug to reference Navigation Menu #45512
Labels
Comments
32 tasks
Related Issue about the ultimate goal and why we need slugs #56247 |
Noting that this came up on a WordPress Freelancer meetup as a current big pain point and blocker for using the site editor. |
Thanks for recording this. Let me know if there's anything outside the above recorded reasons as to why this is a blocker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
This Issue specifically tracks the ongoing effort to use a
slug
to reference a Navigation Menu (wp_navigation
Post) instead of the current postID based setup.This is required because IDs are not consistent across environments. Moreover, it opens the way to improve auto-selection of menus based on location with a site template part hierarchy.
Routes
Currently there are two routes open for exploration:
(Preferred) Key by ID, fetch using existing Data APIs and don't modify REST API
PR: #45443.
This route does not modify the REST API and instead utilises an alternative approach using the existing "collection" endpoint alongside
getEntityRecords
(plural) to retrieve a Navigation Post byslug
.This route was explored due to push back on the attempt to modify the REST API to handle slugs.
Pros:
Cons:
Key by slug and modify REST API to accept slug
PR: #42809.
This route updates the REST API to allow for looking up up menus by
slug
as the unique identifier.Pros:
Cons:
The text was updated successfully, but these errors were encountered: