Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block: When menu is center aligned on mobile, there is no indent or visual indicator for sub-menu items. #45612

Closed
jordesign opened this issue Nov 8, 2022 · 4 comments
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.

Comments

@jordesign
Copy link
Contributor

Description

When using the Navigation Block to create submenus, the mobile view doesn't indicate which is a submenu. This only happens when the menu items are aligned as center.

It seems themes could provide styling for sub-menu items - but it would be good to have sensible defaults as well.

Step-by-step reproduction instructions

  • Create a site with Munchies theme. (or any theme)
  • Create a menu & add submenus (page links).
  • (If not already), center the menu items.

What I expected to happen

When the menu items are aligned left or right, the submenus are indented.

199369221-4da8be27-3840-4add-b3fb-4134849c987c

What actually happened

When the menu items are centered, there is no indication of the submenu.

199369308-16c1aeea-0598-4df1-931d-82f175be069f

Screenshots, screen recording, code snippet

No response

Environment info

WP 6.1
GB 14.4.0

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@carolinan
Copy link
Contributor

How should the submenus be indicated? What kind of style change do you expect or propose?

@carolinan carolinan added the [Block] Navigation Affects the Navigation Block label Nov 9, 2022
@jordesign
Copy link
Contributor Author

I'm happy for that decision to be made by someone with more design expertise... But off the top of my head...

  • We could append a hyphen before child/sub-items. or
  • Default back to left alignment when the mobile nav is used. or
  • introduce tools to change styling/alignment at different break points

@antonyjsmith
Copy link

antonyjsmith commented Dec 6, 2022

I'd suggest they are collapsed [or not] and have a caret icon next to them the same as on the desktop menu which would also address #44346 and make menu behaviour between desktop and mobile more consistent

@jordesign
Copy link
Contributor Author

I'm willing to close this - as the new 'arrow' and 'click to open' functionality coming in WP6.3 allows allows workarounds for folks who want to center align their menu.

@jordesign jordesign closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants