Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snackbar: misc improvements #45824

Open
1 of 6 tasks
ciampo opened this issue Nov 16, 2022 · 2 comments
Open
1 of 6 tasks

Snackbar: misc improvements #45824

ciampo opened this issue Nov 16, 2022 · 2 comments
Labels
[Feature] UI Components Impacts or related to the UI component system [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.

Comments

@ciampo
Copy link
Contributor

ciampo commented Nov 16, 2022

Following up from #45472

  • SnackbarList is not very well-documented (it doesn't even have a README) and prior to this PR, didn't have Storybook examples either. We should re-organize the folder structure, improve the docs and come up with a better Storybook strategy (e.g. use subcomponents and merge Snackbar and SnackbarList in the same file)
  • We should refactor the Notice component to TypeScript and re-use its types in Snackbar
  • I came across a framer-motion bug when clicking rapidly on two Snackbars in a list — the second Snackbar goes transparent but doesn't get fully removed
  • The timeout logic for Snackbar to be dismissed works in a bit of an unexpected way (snackbar items don't get dismissed in order
  • The isDismissible prop from notice data is not taken into account by Snackbar (although this could be on purpose)
  • The Snackbar icon (passed through its icon prop) is not vertically centered, doesn't seem to work well with WordPress icons
@ciampo ciampo added [Type] Enhancement A suggestion for improvement. [Feature] UI Components Impacts or related to the UI component system [Package] Components /packages/components labels Nov 16, 2022
@github-actions
Copy link

Hi,
This issue has gone 180 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the Needs Testing Needs further testing to be confirmed. label May 16, 2023
@ciampo
Copy link
Contributor Author

ciampo commented May 16, 2023

Still relevant

@ciampo ciampo removed the Needs Testing Needs further testing to be confirmed. label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

1 participant