Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Link: Handle rich text better in the label #46055

Closed
scruffian opened this issue Nov 25, 2022 · 8 comments
Closed

Navigation Link: Handle rich text better in the label #46055

scruffian opened this issue Nov 25, 2022 · 8 comments
Labels
[Block] Navigation Link Affects the Navigation Link Block

Comments

@scruffian
Copy link
Contributor

What problem does this address?

When navigation links contain formatting, this gets displayed in the label as HTML.
Screenshot 2022-11-25 at 13 07 25

What is your proposed solution?

I'm not sure, but we need to find an input that allows formatting.

@scruffian scruffian added the [Block] Navigation Link Affects the Navigation Link Block label Nov 25, 2022
@getdave
Copy link
Contributor

getdave commented Nov 25, 2022

LinkControl handles this already I think. Maybe we should look at how that works?

@draganescu
Copy link
Contributor

My first thought is to build a rich text input :) that looks like a TextControl but supports displaying formatted text. It is possible but a bit weird.

@getdave
Copy link
Contributor

getdave commented Nov 25, 2022

Screen.Capture.on.2022-11-25.at.14-48-35.mp4

Link Control just ignores formatting. It was a compromise we settled on.

@draganescu
Copy link
Contributor

draganescu commented Nov 28, 2022

@getdave it doesn't ignore it, it removes it - but i can't see any better way either :D

@scruffian
Copy link
Contributor Author

The "better way" might be to just replace the inspector controls with the Link UI

@getdave
Copy link
Contributor

getdave commented Nov 28, 2022

The "better way" might be to just replace the inspector controls with the Link UI

Yeh but the simplest next step is to ignore it.

@getdave
Copy link
Contributor

getdave commented Nov 30, 2022

I would recommend reviewing a similar discussion which occurred here between Joen, Ella and myself. It has a lot of good research and discussion.

@scruffian
Copy link
Contributor Author

Closed by #46171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Link Affects the Navigation Link Block
Projects
None yet
Development

No branches or pull requests

3 participants