-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline the width control on flex layouts #46128
Comments
Here's a quick stab (Figma) at a design that compresses this. It's based on your existing work, Jay, just a slight remix:
|
Thanks for thinking this out @jasmussen ! Could the "allow shrinking" toggle conceivably fit within the "fit, fill, fixed" dropdown? Maybe just under the "fixed" option and becoming visible only once it's selected? I ask because adding it in the unit section would force us to create a new component (the unit control value selector only renders a set of values, nothing else) and trying to integrate a toggle in a select control raises questions regarding the semantics (is it going to become a dropdown menu with the select and the toggle? If so, its opening button can no longer be a value from the select; it should be something static) which will are likely to cause some a11y grief. Whereas if we were to put the toggle in the other dropdown, we would essentially be reusing a pattern that already occurs in the post visibility section (when "Password protected" is selected). Another question: do we want to be able to simultaneously set fixed width and height for flex items? The difficulty I anticipate here is that the secondary axis won't behave consistently with the main one regarding fit/fill behaviour or the default responsivity of a fixed size:
|
Good thoughts. Yes, I think there are some options to still explore to thread the needle. Hopefully as we are now able to use the feature in trunk, it can help inform the incoming iterations. |
Worth also noting that some configuration options are only relevant conditionally. For example setting blocks within a Stack to I don't know if the controls need to entertain all of these conditions and disable options where appropriate, or if we should do something like Figma where updating one value will tangentially update others when necessary in order to make the original selection work. Going back to the design, I wonder if it might be helpful to include some on-canvas indicators of what each option will do? E.g. hovering the fill option: |
Could that arrow be spot-color blue? But yes, in-canvas visualizations would be an excellent enhancement to these. |
Here's the current UI:
A couple of things stand out:
Let's explore some design options that address these points.
The text was updated successfully, but these errors were encountered: