Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to implement a generic "constrain tabbing" functionality #4621

Closed
afercia opened this issue Jan 21, 2018 · 1 comment
Closed

Consider to implement a generic "constrain tabbing" functionality #4621

afercia opened this issue Jan 21, 2018 · 1 comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@afercia
Copy link
Contributor

afercia commented Jan 21, 2018

This was mentioned here and there in several other issues but, as far as I know, a specific issue hasn't been created yet. So, there it is.

Some Gutenberg UI components work, more or less, like a "modal". They open a floating panel that is visually placed close to the control that opened it, but actually they're placed in the source very far from it.

There are now a few components to set initial focus, move focus back to the "opener" control, get all the tabbable and focusable element, etc. and they're all very useful components to handle focus in a proper way. However, as far as I know, there's no generic component to constrain tabbing yet.

Some components implement their individual way to constrain tabbing, but other components would need the same feature. Consider for example the Contente Structure Popover:

screen shot 2018-01-21 at 18 19 51

When it opens, it's possible to tab through its focusable elements. However, it's also possible to "tab away" from it and, since it's placed at the end of the source, tabbing away from it leads users to the end of the page. Basically, the whole interfaces gets "skipped".

This kind of components should be treated like a sort of "modal" and, at the very least, tabbing should be constrained within the component. Maybe worth considering a generic higher order utility component for this?

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jan 21, 2018
@mtias
Copy link
Member

mtias commented Jul 9, 2018

Closing as #6987 was implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

2 participants