Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style book: Hide inline block preview when style book is invoked #46394

Closed
madhusudhand opened this issue Dec 8, 2022 · 3 comments
Closed

Style book: Hide inline block preview when style book is invoked #46394

madhusudhand opened this issue Dec 8, 2022 · 3 comments
Assignees
@madhusudhand
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@madhusudhand
Copy link
Member

madhusudhand commented Dec 8, 2022 •
edited
Loading

What problem does this address?

Inline block preview is redundant when 'Style book' is open.

image

What is your proposed solution?

Would it be nice to hide the inline preview when style book is open?
@madhusudhand madhusudhand mentioned this issue Dec 8, 2022
Merged
@noisysocks
Copy link
Member

Good idea. Should be easy to do using the useHasStyleBook hook.

@kathrynwp kathrynwp added [Type] Enhancement A suggestion for improvement. [Feature] Component System WordPress component system labels Dec 12, 2022
@madhusudhand madhusudhand mentioned this issue Dec 13, 2022
Merged
@mirka mirka added Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json and removed [Feature] Component System WordPress component system labels Dec 13, 2022
@madhusudhand madhusudhand mentioned this issue Dec 21, 2022
Closed
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 21, 2022
@mtias
Copy link
Member

mtias commented Dec 21, 2022

How would this handle mobile? Also it might seem a bit weird to have the preview just vanish upon opening the style book.

@madhusudhand
Copy link
Member Author

madhusudhand commented Jan 3, 2023 •
edited
Loading

How would this handle mobile?

I think the style book toggle eye is not available for the smaller screens. Only inline preview is available.

Also it might seem a bit weird to have the preview just vanish upon opening the style book.

Hmm. We could leave it as is and revisit in future if required.

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madhusudhand madhusudhand

Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Style book: Hide inline preview when style book is open WordPress/gutenberg
6 participants
@mtias @mirka @noisysocks @madhusudhand @kathrynwp @priethor