Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared featured blocks and allowed blocks config across sub blocks of Nav block #46540

Closed
getdave opened this issue Dec 14, 2022 · 3 comments
Closed
Labels
[Block] Navigation Affects the Navigation Block

Comments

@getdave
Copy link
Contributor

getdave commented Dec 14, 2022

All blocks which can be sub blocks of Nav block seem to shared

  • allowedBlocks
  • featured blocks (see below)

Let's create a canonical const and shared that between all blocks.


Let's shared this across all these blocks as a standard piece of config

Originally posted by @getdave in #46426 (comment)

@getdave getdave added the [Block] Navigation Affects the Navigation Block label Dec 14, 2022
@scruffian
Copy link
Contributor

I'm not sure we can do this, featured blocks and allowed blocks are different lists containing different items.

@getdave
Copy link
Contributor Author

getdave commented Jun 26, 2023

I think perhaps I meant x2 consts? I was advocating for drying up these constants. They may no longer exist 🤷

@scruffian
Copy link
Contributor

Closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block
Projects
Development

No branches or pull requests

2 participants