Navigation: Make the OffCanvasEditor the default experience.

[scruffian]

What problem does this address?

Based on the feedback on https://make.wordpress.org/test/2022/12/14/fse-program-testing-call-19-running-through-refinements/, let's make the OffCanvasEditor the default experience for the navigation block.

This means removing all references to window?.__experimentalEnableOffCanvasNavigationEditor in the code.

One thing to note is that the global navigation sidebar in the Site Editor is also using this experiment to hide its functionality. This sidebar is not yet ready to be moved out of an experiment, so we should ensure that it remains hidden behind this (or another) flag.

Another thing to be aware of is that this experiment is reliant on the tabs in the inspector controls. Both of these experiments need to be made the default. @aaronrobertshaw do you have a plan for this?

A reminder here are the calls for testing:

• Prototype
• Experimental implementation

[talldan]

It's good to see that an accessibility review has been requested ❤️

Some styling issues I've spotted that might be good to resolve and bring more in line with List View ...

In List View the main focus ring surrounds the entire row, which isn't always the case in the off canvas editor

List View	Off Canvas Editor

Lock and Block Settings icons are not aligned between rows

List View	Off Canvas Editor

Horizontal scroll bars often display

[getdave]

For additional context I've updated the Issue description with links to the x2 calls for testing that were made on Make Blog for this feature over the past few months.

• Prototype
• Experimental implementation

[aaronrobertshaw]

Another thing to be aware of is that this experiment is reliant on the tabs in the inspector controls. Both of these experiments need to be made the default. @aaronrobertshaw do you have a plan for this?

I'll be putting together a PR to stabilize the inspector controls tabs today in the hope we might be able to get it reviewed and merged in time for the next Gutenberg release. That would give us two full Gutenberg releases with it as the default experience before the WordPress 6.2 feature freeze.

[aaronrobertshaw]

#47045 was just merged stabilizing the block inspector tabs experiment.