Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block inserter lacking a clear close button #47016

Open
getdave opened this issue Jan 10, 2023 · 7 comments
Open

Block inserter lacking a clear close button #47016

getdave opened this issue Jan 10, 2023 · 7 comments
Assignees
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Status] In Progress Tracking issues with work in progress

Comments

@getdave
Copy link
Contributor

getdave commented Jan 10, 2023

As reported in #46939 (comment) the block inserter is lacking a clear close button. This makes it very difficult for users of assistive technology to exist the popover.

A clear button should be provided which closes the inserter and returns focus to the last focused element.

@getdave getdave added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] Inserter The main way to insert blocks using the + button in the editing interface [a11y] Keyboard & Focus labels Jan 10, 2023
@draganescu
Copy link
Contributor

This seems to be a feature request for the quick inserter.

@alexstine
Copy link
Contributor

Yes but a must none the less. Not sure how I missed this elsewhere. Maybe I just never used it anywhere else before now. Escape is not a given sadly so having a close button makes it clear.

@carolinan
Copy link
Contributor

I think this needs some design guidance before it can be implemented.

@carolinan carolinan added the Needs Design Needs design efforts. label Jan 19, 2023
@jasmussen
Copy link
Contributor

Related to a conversation here, I'd like to hear thoughts on having it be an on-focus close button that appears, for example, at the end of the list of tabbables.

@ciampo
Copy link
Contributor

ciampo commented Jan 20, 2023

As @jasmussen suggests, could we add a visually hidden button that can be focused via keyboard navigation? The button could become visually visible when focused, similarly to the "skip to content" links that are usually added at the top of a web page.

@getdave
Copy link
Contributor Author

getdave commented Jan 21, 2023

I implemented a proof of concept in #47327

@getdave
Copy link
Contributor Author

getdave commented Jan 30, 2023

Screen Shot 2023-01-30 at 10 18 14 (1)

Here's an example of where we already include a clear Close button in the UI. I wonder whether would could borrow the same pattern?

@getdave getdave added the Needs Design Feedback Needs general design feedback. label Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants