Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve custom block style presentation in the block editor #47146

Closed
carolinan opened this issue Jan 13, 2023 · 3 comments
Closed

Improve custom block style presentation in the block editor #47146

carolinan opened this issue Jan 13, 2023 · 3 comments
Labels
[Feature] Theme Style Variations Related to style variations provided by block themes [Type] Enhancement A suggestion for improvement.

Comments

@carolinan
Copy link
Contributor

What problem does this address?

Now that custom block styles shows as selectable style variations in global styles,
it feels like the presentation in the block editor is dated and could be improved.

For example, the label of the panel in the block editor is Styles, which is the same as the first tab in the settings sidebar:

The block settings sidebar of the button block, with a tab and a panel called Styles

While in global styles they are labeled "Style variations". I think we need to use the same name across the interface.
The button block in the global styles, with a panel of style variations below the settings.

Also kindly note that in the styles sidebar a single variation is presented on one full row and showing the full name,
while in the block editor, the names are often truncated and difficult to read because of the short width of the button,
please see #40331

I understand that not all will agree, because it takes up a lot of space, and it might be difficult to find a middle way,
but I much prefer the preview that is in the panel, over the pop out used in the editor because the pop out only shows on hover and is flickery.
Image block style variation is displayed in a separate modal outside the panel when hovering over the button that lets you select the variation

@carolinan carolinan added [Feature] Theme Style Variations Related to style variations provided by block themes [Type] Enhancement A suggestion for improvement. labels Jan 13, 2023
@carolinan
Copy link
Contributor Author

Ah, and also the tooltip that shows when you hover over the button that lets you select the style seems unnecessary since the text is already visible. We could remove this duplication.

@ghost
Copy link

ghost commented Jan 14, 2023

Ah, and also the tooltip that shows when you hover over the button that lets you select the style seems unnecessary since the text is already visible. We could remove this duplication.

We could remove this duplication... when a style name is fully readable.
When style names are truncated, the tooltip is necessary. •́ ‿ ,•̀

@carolinan
Copy link
Contributor Author

So let's give them the space they need 😃

@carolinan carolinan closed this as not planned Won't fix, can't repro, duplicate, stale Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Theme Style Variations Related to style variations provided by block themes [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

1 participant