-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several blocks are missing has-link-color class on the front #47233
Comments
@ramonjd I am not up to date with what is planned for these class names: am I now expected to update the block's php file using the WP_HTML_Tag_Processor? Is the gallery block and heading block the best references for learning about the tag processor? |
Since the tag processor will not be in 6.2, this is unblocked and I will start working on adding the classes manually. |
These blocks are more relevant for block themes but are all missing the comment author name post template query no results site title term description |
Description
When the post terms block has a link color set, the has-link-color class is present in the editor and not the front.
This is causing a problem for https://core.trac.wordpress.org/ticket/56487, enabling appearance-tools theme support for bundled themes.
In Twenty Twenty-One the link color contrast is meant to change depending on the background color, unless there is a custom link color set, so it relies on this class being present in both the editor and front.
Update: This is also the case with
I have not had the chance to test all blocks that has link color options yet.
Step-by-step reproduction instructions
In the editor, add a post terms block.
Select a link color from the color picker.
View the source for the block in the editor and confirm that it has the
has-link-color
class.Save and view the front. Confirm that the block no longer has the
has-link-color
class.Screenshots, screen recording, code snippet
No response
Environment info
Gutenberg trunk
WordPres 6.2 alpha.
Twenty Twenty-One.
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: