Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block variations are missing Global Styles support #47324

Open
danieldudzic opened this issue Jan 21, 2023 · 2 comments
Open

Block variations are missing Global Styles support #47324

danieldudzic opened this issue Jan 21, 2023 · 2 comments
Labels
[Block] Query Title Affects the Query Title Block [Feature] Block Variations Block variations, including introducing new variations and variations as a feature [Feature] Extensibility The ability to extend blocks or the editing experience [Focus] Blocks Adoption For issues that directly impact the ability to adopt features of Gutenberg. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@danieldudzic
Copy link

What problem does this address?

In WooCommerce Blocks, we are using a number of block variations of core blocks:

  • Products (beta) - variation of Query Loop
  • Product Title - variation of Post Title
  • Product Summary - variation of Post Excerpt

Currently, the only way to apply Global Styles to block variations is to apply them to their core origin block, which leads to a confusing experience.

For example: A user trying to change Gobal Styles for the Product Summary needs to find the Post Excerpt on the list of available blocks and somehow make the connection that changes made to it will also apply to the Product Summary.

Editor__beta__‹ratings—_WordPress_and_Messenger

Product Title and Product Summary are a good example of why it makes sense to allow for independent styling (They exist in a quite different context from the Post Title and Excerpt, and will tend to have a quite different length, size, surrounding items).

What is your proposed solution?

Add Global Styles support for block variations.

@carolinan
Copy link
Contributor

carolinan commented Jan 23, 2023

Another example unrelated to third party variations is the Query title block. The query title shows in the block list in global styles, but archive title and search titles do not.

If you directly insert an archive title or search title in the editor, you may never know that these are variations of the same block which has a different name. This makes it difficult to discover the styling options.

The variations are not searchable. If you enter "archive" in the search input field, only the archives block, calendar and term description shows up, the query title block does not.

Aside: If I enter the word search in the search field, the heading block and site title and site title shows up. That is unexpected because they are unrelated.

@carolinan carolinan added [Feature] Block Variations Block variations, including introducing new variations and variations as a feature [Block] Query Title Affects the Query Title Block Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement. labels Jan 23, 2023
@annezazu annezazu moved this to 📋 Backlog in Gutenberg Phase 2: Customization Apr 5, 2023
@annezazu annezazu added the [Focus] Blocks Adoption For issues that directly impact the ability to adopt features of Gutenberg. label Jun 5, 2023
@ndiego ndiego added the [Feature] Extensibility The ability to extend blocks or the editing experience label Jun 5, 2023
@colorful-tones
Copy link
Member

Hi folks,
We are only one week away from the Beta 1 cut-off date for WordPress 6.6. This issue hasn’t seen any movement in a while, so we (the editor triage leads of the 6.6 release) have decided to remove it from the WordPress 6.6 Editor Tasks project board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Title Affects the Query Title Block [Feature] Block Variations Block variations, including introducing new variations and variations as a feature [Feature] Extensibility The ability to extend blocks or the editing experience [Focus] Blocks Adoption For issues that directly impact the ability to adopt features of Gutenberg. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
Status: 📋 Backlog
Development

No branches or pull requests

5 participants