Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Control - Add support for text only labels instead of relying on icons alone to communicate meaning. #47545

Closed
getdave opened this issue Jan 30, 2023 · 8 comments
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time

Comments

@getdave
Copy link
Contributor

getdave commented Jan 30, 2023

Add support for text only labels instead of relying on icons alone to communicate meaning.

To see the current state toggle on the "Show button text labels" option under editor preferences:

Screen Shot 2023-01-30 at 10 17 06


The link control panel settings don't support the text control options. (Options > Preferences > Show button text labels)

Originally posted by @joedolson in #47310 (comment)

@getdave getdave added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels Jan 30, 2023
@getdave getdave changed the title A few comments from an accessibility standpoint: Link Control - Add support for text only labels instead of relying on icons alone to communicate meaning. Jan 30, 2023
@abhi3315
Copy link
Contributor

abhi3315 commented Feb 8, 2023

@getdave RN I am just seeing a single icon in the Link Control. Do I have to add the support to change this icon to the label text?

image

@getdave
Copy link
Contributor Author

getdave commented Feb 8, 2023

@getdave RN I am just seeing a single icon in the Link Control. Do I have to add the support to change this icon to the label text?

👋 I'm not sure what RN means, but yes it needs to handle any icons shown and have a text based equivalent. I believe there is a standard mecahnic for this because the Gutenberg toolbars implement this pattern.

@abhi3315 Are you planning to work on this?

@getdave getdave added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Feb 8, 2023
@abhi3315
Copy link
Contributor

abhi3315 commented Feb 8, 2023

RN stands for Right Now 😅

@getdave Yes, I am looking forward to contribute this issue.

@getdave
Copy link
Contributor Author

getdave commented Feb 8, 2023

That's great to hear. Happy to review PRs. Thank you!

@abhi3315
Copy link
Contributor

abhi3315 commented Feb 9, 2023

@getdave I have added this feature to LinkControl. But I have a query, the label uses aria-label to display the label. But in the case of LinkControl, the text is too big (Toggle link settings).

Should I change the aria-label to something like Setting or Link Settings?
And should I disable the tooltip when only labels are enabled?

image

@abhi3315
Copy link
Contributor

abhi3315 commented Feb 9, 2023

And should I disable the tooltip when only labels are enabled?

Tooltips are also enabled for the other toolbar items so we can ignore this.

image

@abhi3315
Copy link
Contributor

abhi3315 commented Feb 9, 2023

@getdave Please review the PR. #47930

@juanfra
Copy link
Member

juanfra commented Jun 14, 2023

Seems like this one was resolved with #47930 - I'm closing this issue, but feel free to re-open if needed.

@juanfra juanfra closed this as completed Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time
Projects
None yet
Development

No branches or pull requests

3 participants