Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation editable list view transfers focus to canvas when editing a menu item #47607

Open
getdave opened this issue Jan 31, 2023 · 4 comments
Labels
[Block] Navigation Affects the Navigation Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@getdave
Copy link
Contributor

getdave commented Jan 31, 2023

Currently when using a keyboard (or assitive tech) to use the Nav block's list view editing focus is not managed as you'd expect.

Clicking "Edit" on a node causes the block to be selected (good) and focus to be transferred to the editor canvas (bad).

The focus should be placed on the inspector controls for the selected block. There is currently no programmatic interface that allows us to achieve this. Therefore users are required to manually move focus to the inspector controls which results in a lot of context switching.

Moreover, once you have finished editing and you go "back" to the Nav block, the list view is not focused. Again this requires you to manually move focus back to the list view.

@getdave getdave added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Block] Navigation Affects the Navigation Block [a11y] Keyboard & Focus labels Jan 31, 2023
@jeryj
Copy link
Contributor

jeryj commented May 18, 2023

Editing navgivation from inspector sends focus to canvas

Is this gif showing the interaction you mean? When editing an item from the sidebar block tools, the focus should be sent to the form in the sidebar that opens, but instead it's being sent to the editor canvas?

@getdave
Copy link
Contributor Author

getdave commented Nov 21, 2024

@jeryj Yes that's it. It's because we have to selectBlock() to show the inspector controls. But that causes focus to jump into the canvas.

Ideal solution:

  • the block in the canvas is highlighted somehow
  • the focus remains in the List View sidebar where editing was happening

I wonder if selectBlock has any options to cancel the auto-focusing of canvas?

@getdave getdave changed the title Nav list view editing manage focus when editing Navigation editable list view transfers focus to canvas when editing a menu item Nov 21, 2024
@getdave

This comment has been minimized.

@getdave

This comment has been minimized.

@getdave getdave reopened this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants