-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Editor: consistent name for the Edit buttons #47780
Comments
You also mentioned that the button text changes depending on screen size? |
As mentioned in #47343 (comment) by @afercia
Actually, this |
Ah, so on mobile it's a two-steps flow. I missed that.
To be fair, I think that's a bit confusing. When in the mobile view, I'm not sure what's the purpose of showing the preview in the first place. On desktop, the preview is visible while I navigate through the templates. Instead, on mobile the preview is initially hidden. As a user, when I click 'View editor' I would expect to be in the Editor in edit mode. Why do I need an intermediate step for the preview? Couple more notes: 1 2 On desktop, the 'Edit' button disappears. That makes totally sense, as there's nothing to 'Edit' in the templates list: Instead, on mobile the 'View editor' button is still there: That's arguably correct as clicking on 'View editor' doesn't bring me to the Editor in edit mode. Instead, it brings me to the templates list: In the templates list I would expect to see the 'Add New' button at the top right. Instead, I see the 'Edit' button. Clicking this button doesn't edit anything. Instead, it makes the top bar change and finally shoe the 'Add New' button: Overall, it appears there's still a lot of room for improvement in this flow. |
@afercia I do agree. We have to think of a clear flow in the mobile screens and break down it into smaller tasks |
Thank you @benridane yes that's correct. To recap the current state of this issue: Many things have changed in the meantime:
|
Description
Follow up to #47343
Actually, in the Site Editor there are two buttons to switch the editor from 'Browse mode' to 'Edit mode':
role="button"
attribute and an aria-label 'Editor canvas'.These buttons do the same thing and should have the same name. The name should clearly communicate the action.
'Editor canvas' isn't ideal. For consistency and clarity, it should be changed to 'Edit'.
Step-by-step reproduction instructions
role="button"
is 'Editor canvas'.Screenshots, screen recording, code snippet
The two buttons as announced by VoiceOver:
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: