-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional CSS - hidden by design #47887
Comments
cc @richtabor |
I agree with the issue. |
This is a tough one. Ideally block themes wouldn't need custom CSS — instead leveraging Global Styles to personalize every block added to the site. The more custom CSS added, the more likelihood of styles breaking/conflicting with Global Styles. But its important for advanced users to be able to extend with custom CSS, so its added to Global Styles — but not front-and-center, to reduce the likelihood of it causing unintentional confusion/conflicts. And once you add custom CSS, it'll be visible at the top-level of Global Styles, so you don't have to keep opening up the menu item for it. 👍 |
I believe this issue wasn't opened for lack of understanding about the change. We already know this. I praise the concern behind it, but it seems to be an overengineered change to me and maybe for the author too. It brings unnecessary logic about how it works, when it appears or not, and it is bad positioned now. I understand it may be subjective our point of view regarding the best position, but yours seems too. What is the criteria for menu items in this context? Normally they are help, tools, and secondary actions. |
Maybe an |
Because of the complexities/inherit challenges you'll run into applying custom CSS globally to blocks (in lieu of using Global Styles), the Additional CSS control should not have the same weight as styling all the blocks. That's not subjective, but cautionary. If you're an advanced user, and want to add additional CSS to your site, you take the extra step to enable it. That extra step is imperative to reducing those complexities for non-advanced users (who may not even understand what CSS is). For reference, here's what it looks like with additional CSS added to a site: |
To continue the current Global Styles UX patterns, we'd need to do a drill down from Advanced, to the entry point of Additional CSS - which you'd then click to open the next panel. But I'm not confident that discoverability is an issue. Sure we can definitely improve how its invoked and add more context, but bringing it top-level will lead to far more issues than it's worth. |
A) At the moment the UI for additional CSS is inconsistent in any way. B) Your attempt to hide additional CSS is useless at all. There are a lot of Plugins to add CSS to WordPress. And they work for Classic Themes AND Full Site Editing Themes. |
Well, feedback from 2 people. Real usage. I am going to add that there is No problem on keeping the current direction, and I don't want to stress the team when writing my feedback. Once that is said, WordPress is made by awesome and skilled people, including the Design team here present. Design is scientific. And few projects on the internet are so good on their practices, management, and this interaction to the public. However, as nothing is perfect, one area that this project does bad, SO bad, or in other words, one area in which WordPress has room for improvement, is on the decision making. Everything related to achieving consensus, you just need to read the issues to understand this is always the pain point. In so many decisions, we read "I believe this is better". "It is going to bring problems". "Let's deliberate". "Follow the mockups". It is wrong to think that someone, as skilled as it can be, is capable of seeing everything. It is wrong to think that a decision made by a team, as skilled as it can be, and as immersed in the community as it can be, is capable of satisfying all points of views, wishes, etc. This is NEVER going to be enough and therefore it is a constant to repeat discussions like the current one. Because there is one single "enlightenment" missing on the decision making: Feedback collected fom annezazu, for example, is great and valuable indeed. Criterias exposed by Rich Tabor are also valuable, as one can see. Both positions should remain. However the feedbacks collected in these scenarios happen AFTER changes were conceived and later implemented. This is not a problem that is going to be solved by training the team, which is dealing as well as it can here. The root meditation that I am writing, with much patience, to make my feedback be heard, is regarding the fact that there is not enough people's participation in deliberations YET, in the process making YET. and the existence of this YET is a decision. They believe that post-Feedbacks are enough to catch something alarming. However, how to participate on the mockups? On the planning direction? When we write feedback, for example on this issue, everything is so difficult to change then. We are presented by the internal docs, the deliberations... As if we were missing the point. What we are missing is indeed the voice, the right moment to join in. No one doubts the work behind it, and it is elegant indeed. WordPress is striving, because the team remains amazing, and capable of implementing a difficult project. But the mockups were never enough to represent our feedbacks. What a gap!!! An intermediate state is missing and could be: let's collect feedback NOW on the MOCKUPS, on the planning. Let's create a public temporary group to discuss this mockup. This planning, WHILE it is being planned, let's invite the public. Only then publish it, and start the process to create issues, in order to implement it. Too long to read: There is so much distinction between end-user, developer, as if the experience had layers. There is need to decide now, if keeping the planning is the solution, or to put security aside in order to consider our free feedback and experience with your product. To believe on the planning and the team decision, AND to BELIEVE on our experience TOO. Ideally not later, to invite our thinking to contribute to your planning is wiser. We are using your product and disliking it. Although my phrasings are a bit strong sometimes, my comment is NOT meant to be disrespectful, to anyone!!!!. It is just a "call to wake up". A free consultant work, hey owner Matt ;-) I repeat my suggestion: there should be feedback participation on the planning stages of features, while they are being planned. This increases quality, as it decreases tension and uncertainty to a minimum. By doing so, planning, mockups, decisions are not only going to be released, exposed. The whole process is going to be more organic, with public participation. Fundamental decisions like the current one are going to be a more considerate process, with less chances of reverting or needing a substantial rework later on. All the best, |
Description
Additional CSS should work like same option in customizer.
And in was OK in Gutenberg 15.0
But hidden by design in 15.1 behind 3 dots menu, where no one would ever look for it!
Congratulations! (It was not hidden in Customizer, why hide it in styles?)
But to make it really crazy: It is always visible - like it should be - in styles of individual Blocks!
Which additional visible whole site CSS option in 3 dots menu above - to make it confusing as possible.
Which - after inserting some CSS - appears in the interface. => Design by miracle!
If You do not want anybody using additional CSS, don't implement it! - But implementing it and hiding it afterwards is useless.
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
No response
Environment info
WP 6.1 - Betatester
Gutenberg 15.1.0 RC1
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: