Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme.json: Add granular control to appearance tools #47925

Open
scruffian opened this issue Feb 9, 2023 · 2 comments
Open

Theme.json: Add granular control to appearance tools #47925

scruffian opened this issue Feb 9, 2023 · 2 comments
Labels
[Focus] Blocks Adoption For issues that directly impact the ability to adopt features of Gutenberg. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@scruffian
Copy link
Contributor

What problem does this address?

An idea that arose in #47675 is that we could give theme.json more granular control of the appearance tools that are enabled in a theme.

What is your proposed solution?

We could use a syntax like this:

    "settings": {
        "appearanceTools": {
            'link-color' => true,
            'border'  => true,
        },    
    },
@scruffian scruffian added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Feb 9, 2023
@scruffian scruffian mentioned this issue Feb 9, 2023
Closed
@annezazu annezazu added the [Focus] Blocks Adoption For issues that directly impact the ability to adopt features of Gutenberg. label Feb 10, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Jul 27, 2023
@bph
Copy link
Contributor

bph commented Oct 9, 2023 •
edited
Loading

@scruffian Looking at the documentation , this seems to be completed. If you concur, we can close this issue..

@scruffian
Copy link
Contributor Author

I don't think so. At the moment appearanceTools just turns on all of those settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Focus] Blocks Adoption For issues that directly impact the ability to adopt features of Gutenberg. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bph @scruffian @jordesign @annezazu