Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up default aspect ratio values #48041

Closed
richtabor opened this issue Feb 13, 2023 · 2 comments · Fixed by #55053
Closed

Clean up default aspect ratio values #48041

richtabor opened this issue Feb 13, 2023 · 2 comments · Fixed by #55053
Assignees
@richtabor
Labels
[Block] Post Featured Image Affects the Post Featured Image Block Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

richtabor commented Feb 13, 2023 •
edited
Loading

Now that aspect ratio has landed in the Post Featured Image block in #47854 (based on the values from the hard-crop edit tool in the Image block) let's circle back and clean up the available aspect ratios.

I'm proposing we drop 16:10 and 10:16.

Current:

  • Original
  • Square
  • 16:10
  • 16:9
  • 4:3
  • 3:2
  • 10:16
  • 9:16
  • 3:4
  • 2:3

Proposed:

  • Original
  • Square
  • 16:9
  • 4:3
  • 3:2
  • 9:16
  • 3:4
  • 2:3

Visuals:

Current aspect ratios:

CleanShot 2023-02-13 at 13 51 30
@richtabor richtabor added [Block] Post Featured Image Affects the Post Featured Image Block Needs Design Feedback Needs general design feedback. labels Feb 13, 2023
@richtabor
Copy link
Member Author

Related in part #47963

@richtabor richtabor mentioned this issue Feb 14, 2023
Open
13 tasks
@richtabor richtabor mentioned this issue Mar 9, 2023
Merged
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Jul 27, 2023
@richtabor
Copy link
Member Author

Here are the options we currently have in the aspect ratio added to the image block:

CleanShot 2023-10-04 at 12 29 56

@richtabor richtabor mentioned this issue Oct 4, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richtabor richtabor

Labels
[Block] Post Featured Image Affects the Post Featured Image Block Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
Polish
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove 16:10 from 10:16 options from AspectRatioDropdown WordPress/gutenberg
2 participants
@richtabor @jordesign