Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aspect ratio support to image block placeholder state #48081

Closed
richtabor opened this issue Feb 14, 2023 · 1 comment · Fixed by #54216
Closed

Add aspect ratio support to image block placeholder state #48081

richtabor opened this issue Feb 14, 2023 · 1 comment · Fixed by #54216
Assignees
@draganescu
Labels
[Block] Image Affects the Image Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

The core/image block does not currently allow for dimensions or aspect-ratio (#38990), before an image is added to the block.

I propose we remove the need to set an image in place, before assigning any dimensions/aspect ratio, to further simplify designing within the editor. One shouldn't be required to have an image in mind before laying out the contents of a page.

Note that this issue is blocked by first adding support for aspect ratio within the Image block (#38990).
@richtabor richtabor added [Type] Enhancement A suggestion for improvement. [Block] Image Affects the Image Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Feb 14, 2023
@richtabor richtabor mentioned this issue Feb 14, 2023
Open
13 tasks
@richtabor richtabor mentioned this issue Mar 17, 2023
Open
26 tasks
@gaambo
Copy link
Contributor

gaambo commented Aug 22, 2023 •
edited
Loading

I'd like to mention #39457 here as well. It's about keeping a set image size when changing the image. And IMHO, it's as important as the aspect ratio for patterns.

@richtabor richtabor mentioned this issue Aug 30, 2023
Closed
@carolinan carolinan mentioned this issue Aug 30, 2023
Closed
@draganescu draganescu self-assigned this Sep 6, 2023
@draganescu draganescu moved this from Todo to In Progress in Automattic team Ignite's project board Sep 6, 2023
@draganescu draganescu mentioned this issue Sep 6, 2023
Merged
@mikachan mikachan moved this to In Progress in WordPress 6.4 Editor Tasks Sep 6, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in WordPress 6.4 Editor Tasks Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@draganescu draganescu

Labels
[Block] Image Affects the Image Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
Automattic team Ignite's project board
Archived in project
WordPress 6.4 Editor Tasks
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add aspect ratio to image placeholder WordPress/gutenberg
3 participants
@draganescu @richtabor @gaambo