Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to post comments in Status panel #4867

Closed
jasmussen opened this issue Feb 5, 2018 · 10 comments
Closed

Add link to post comments in Status panel #4867

jasmussen opened this issue Feb 5, 2018 · 10 comments
Labels
[Feature] Document Settings Document settings experience [Status] Not Implemented Issue/PR we will (likely) not implement.

Comments

@jasmussen
Copy link
Contributor

In the classic editor, comments on a post show up in a box below the editor. This is a useful way to moderate comments on an individual post. We have no UI for this in Gutenberg, but there's another interface for moderating comments on a single post, in the posts section.

Specifially if you load up the comments page, and click the comments icon next to a post, you see a list of comments just for that post, with a URL something like /wp-admin/edit-comments.php?p=9036&comment_status=approved. We should leverage that in Gutenberg.

Here's a suggested mockup:

screen shot 2018-02-05 at 11 26 23

@jasmussen jasmussen added the Needs Design Feedback Needs general design feedback. label Feb 5, 2018
@jasmussen
Copy link
Contributor Author

CC: @karmatosed — I've been doing a bunch of spring cleaning with Gutenberg on my blog, and often found the need to look at comments for an old post. This UI would be easy to do, and would fix it for me.

@karmatosed
Copy link
Member

This is a great little improvement that could be done. One point, on clicking the comments, how do I get back to the post? Does it save on click to ensure that I don't lose content?

@jasmussen
Copy link
Contributor Author

You'd just press the browser back button to go back, but good point about the auto save, we'd probably want to fire a save indeed.

@youknowriad
Copy link
Contributor

Do we really want to trigger a save, I'm thinking the "dirty popup" would show up if there are unsaved changes which is fine enough IMO.

Trigger save would add a bit of complexity, that I'd prefer avoiding if we can.

@jasmussen
Copy link
Contributor Author

V1 could be without the save, then we can see if we need it?

@youknowriad
Copy link
Contributor

@jasmussen yes we can, but It might be a good idea to just keep it without it as it's a more consistent behavior. It's not the only place in the UI where we link to external pages: Revisions, published post link, all WPAdmin menu links :), I believe we have some help links as well.

@karmatosed karmatosed added [Feature] Document Settings Document settings experience and removed Needs Design Feedback Needs general design feedback. labels Feb 17, 2018
@bobbingwide
Copy link
Contributor

Can anyone explain why there isn’t a meta box for comments. What design decision was made? This needs to be documented for users who are unable to find the box they expect to see.

@mtias mtias added the Needs Design Feedback Needs general design feedback. label Jul 17, 2018
@karmatosed
Copy link
Member

This is a good little addition so let's close out design feedback on this.

@bobbingwide comments still function the same with discussion on/off switches and the link, it doesn't have to be a separate section and still has hooks.

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Jul 29, 2018
@mtias mtias added the Needs Decision Needs a decision to be actionable or relevant label Oct 7, 2018
@gziolo gziolo added [Status] Not Implemented Issue/PR we will (likely) not implement. and removed Needs Decision Needs a decision to be actionable or relevant labels May 23, 2019
@gziolo
Copy link
Member

gziolo commented May 23, 2019

Any plugin can add such information with PluginPostStatusInfo component through registerPlugin API. I think it's okay to close this issue. @jasmussen thanks for sharing your proposal. We can always revisit later.

@gziolo gziolo closed this as completed May 23, 2019
@lkraav
Copy link

lkraav commented Sep 18, 2019

Can anyone explain why there isn’t a meta box for comments. What design decision was made? This needs to be documented for users who are unable to find the box they expect to see.

This question was never answered for some reason. I'm looking at today's Gutenberg 6.5.0 post edit screen, and I don't see a comments meta box available either. What am I missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Document Settings Document settings experience [Status] Not Implemented Issue/PR we will (likely) not implement.
Projects
None yet
Development

No branches or pull requests

7 participants