Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captions should not be discarded when toggled off #49081

Open
richtabor opened this issue Mar 14, 2023 · 3 comments
Open

Captions should not be discarded when toggled off #49081

richtabor opened this issue Mar 14, 2023 · 3 comments
Labels
[Feature] Media Anything that impacts the experience of managing media [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

What problem does this address?

If you toggle off a caption, the caption cannot be simply toggled back on—you have to re-write it. Yes, you can use the undo action, but only in this moment. And I wouldn't expect the caption to be deleted and hidden.

What is your proposed solution?

  • When toggled on, the caption is visible/ready to be edited.
  • When toggled off, the caption is no longer rendered (but still saved as an attribute).

Visual

Current flow, where captions are discarded when the caption icon is toggled:

CleanShot.2023-03-14.at.15.24.04.mp4
@richtabor richtabor added [Type] Enhancement A suggestion for improvement. [Feature] Media Anything that impacts the experience of managing media labels Mar 14, 2023
@richtabor richtabor changed the title Make media captions not destructive Captions should not be discarded when toggled off Mar 14, 2023
@Mamaduka
Copy link
Member

I also noted this when the new Toolbar toggle was introduced #45112 (comment).

@carolinan
Copy link
Contributor

Thank you for opening this issue

@porg
Copy link

porg commented Aug 11, 2023

🙂 Glad that someone else also had that feature proposal which I demoed in this video:

WordPress.Image.Block.Toggle.Caption.without.data.loss.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Media Anything that impacts the experience of managing media [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants