Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image block placeholder not showing border or radius #49144

Closed
annezazu opened this issue Mar 16, 2023 · 2 comments · Fixed by #49569
Closed

Image block placeholder not showing border or radius #49144

annezazu opened this issue Mar 16, 2023 · 2 comments · Fixed by #49569
Assignees
Labels
[Block] Image Affects the Image Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

Description

The placeholder for the image block no longer reflects border or radius changes.

Step-by-step reproduction instructions

  1. Add an image block.
  2. Open block settings and change border and/or radius.

Screenshots, screen recording, code snippet

placeholder.border.and.radius.mov

Environment info

WP 6.2 RC2 with and without GB 15.3.1

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Block] Image Affects the Image Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Mar 16, 2023
@ndiego ndiego moved this to ❓ Triage in WordPress 6.2 Editor Tasks Mar 17, 2023
@Mamaduka
Copy link
Member

This bug was introduced in 6.1, not in 6.2. Technically, this should not be fixed during 6.2's RC cycle.

@ndiego ndiego moved this from ❓ Triage to 🦵 Punted to 6.3 in WordPress 6.2 Editor Tasks Mar 20, 2023
@annezazu annezazu moved this to 💻 Needs development in Gutenberg Phase 2: Customization Mar 22, 2023
@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. and removed [Type] Bug An existing feature does not function as intended labels Apr 4, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 4, 2023
@aaronrobertshaw
Copy link
Contributor

The placeholder for the image block no longer reflects border or radius changes.

Digging into this issue, it appears more a gap rather than a bug per se. The Post Featured Image block has its borders applied to the placeholder but this wasn't the case for the Image block.

I've updated the Image block in #49569 so it will apply any borders to its placeholder content but only when the block isn't selected.

@github-project-automation github-project-automation bot moved this from 🦵 Punted to 6.3 to ✅ Done in WordPress 6.2 Editor Tasks Apr 18, 2023
@github-project-automation github-project-automation bot moved this from 💻 Needs development to ✅ Done in Gutenberg Phase 2: Customization Apr 18, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants