Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DuotonePicker: Tooltip renders underneath UI #49225

Closed
mirka opened this issue Mar 21, 2023 · 0 comments · Fixed by #49245
Closed

DuotonePicker: Tooltip renders underneath UI #49225

mirka opened this issue Mar 21, 2023 · 0 comments · Fixed by #49245
Assignees
@ciampo
Labels
[Feature] Colors Color management [Package] Components /packages/components [Type] Bug An existing feature does not function as intended

Comments

@mirka
Copy link
Member

mirka commented Mar 21, 2023

What problem does this address?

In the Storybook story for DuotonePicker, the swatch tooltips are rendered underneath the duotone bar:

Screenshot of tooltip layered underneath

What is your proposed solution?

Usually this is fixed by wrapping the component in a SlotFillProvider:

<SlotFillProvider>
  <MyComponent />
  <Popover.Slot />
</SlotFillProvider>

This does not seem to be sufficient in this case.
@mirka mirka added the [Package] Components /packages/components label Mar 21, 2023
@mirka mirka mentioned this issue Mar 21, 2023
Merged
@kathrynwp kathrynwp added [Type] Bug An existing feature does not function as intended [Feature] Colors Color management labels Mar 21, 2023
@ciampo ciampo mentioned this issue Mar 21, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 21, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ciampo ciampo

Labels
[Feature] Colors Color management [Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
4 participants
@mirka @ciampo @kathrynwp @priethor