Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Classic block to better resemble the current editor #4926

Closed
jasmussen opened this issue Feb 7, 2018 · 6 comments
Closed

Update Classic block to better resemble the current editor #4926

jasmussen opened this issue Feb 7, 2018 · 6 comments
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... Needs Dev Ready for, and needs developer efforts
Milestone

Comments

@jasmussen
Copy link
Contributor

The Classic block has caused confusion in a number of ways since the start, which has caused the name to change from "Freeform" to "Classic Text" to "Classic". It's also hard to visually distinguish from the Paragraph blocks, causing confusion because the interactions are very different. Alignments in the paragraph block work at the block level, whereas you can have multiple paragraphs with different alignments inside a Classic block, as well as a multitude of other content.

What if we made the Classic block reflect the styling of the current editor? It would have the following benefits:

  • Reduce confusion as to the difference between a Paragraph block and the Classic block
  • Provide some recognition for users migrating to Gutenberg
  • By not changing the UI, we can better support TinyMCE specific plugins like TinyMCE advanced

Here's a mockup:

classic_editor_block

@jasmussen jasmussen added the Needs Design Feedback Needs general design feedback. label Feb 7, 2018
@mtias mtias added [Component] TinyMCE [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... labels Feb 7, 2018
@StaggerLeee
Copy link

StaggerLeee commented Feb 7, 2018

Would like to ask if you can reconsider making content area wider. It will be wider in at least 60-70% of front-end cases. I know you cannot scan PHP code and find out what is width set in theme. One single line filter to decide width of Gutebnerg would help a lot.

As it is now a lot much empty space around.

@ellatrix
Copy link
Member

ellatrix commented Feb 7, 2018

@StaggerLeee This seems to be unrelated to this issue. Maybe create a new one?

@ellatrix
Copy link
Member

ellatrix commented Feb 7, 2018

I love this. I would also suggest to just leave the toolbar visible, regardless of block selection, to make clear at all times that it is a classic editor. Unlike other blocks, this falls out of the regular block experience, so the user is kind of "on their own" within this area. It's also not always easy to get out of it as pressing enter will just keep you inside the block. Added images may look like they are blocks but they are not. Etc.

@jasmussen
Copy link
Contributor Author

Would like to ask if you can reconsider making content area wider. It will be wider in at least 60-70% of front-end cases. I know you cannot scan PHP code and find out what is width set in theme. One single line filter to decide width of Gutebnerg would help a lot.

At some point we will refactor the main column to address #1483. That should make it possible for the editor to comply with widths that are set by the theme itself.

@karmatosed
Copy link
Member

+1 for this.

@karmatosed karmatosed added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Mar 6, 2018
@karmatosed karmatosed added this to the Merge Proposal milestone Mar 6, 2018
@ellatrix
Copy link
Member

ellatrix commented Mar 7, 2018

PR linked should be ready apart from the initial focus issue. Cannot do much there without it updated in TinyMCE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... Needs Dev Ready for, and needs developer efforts
Projects
None yet
Development

No branches or pull requests

5 participants