Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Distraction Free mode have Edit and Select modes? #49314

Open
richtabor opened this issue Mar 23, 2023 · 2 comments
Open

Should Distraction Free mode have Edit and Select modes? #49314

richtabor opened this issue Mar 23, 2023 · 2 comments
Labels
[Feature] Distraction Free A preference in the Post and Site Editor that limits distractions to focus the editing experience Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

Much of the UI has been pared back for Distraction Free mode. Is it necessary to have the Edit and Select mode controls available?

CleanShot 2023-03-23 at 12 13 39

@richtabor richtabor added the Needs Design Feedback Needs general design feedback. label Mar 23, 2023
@jasmussen
Copy link
Contributor

Good ticket. Mainly on a meta level, it surfaces an issue around that tooling, which I think is worth discussing moreso than whether it's available in distraction free mode. If we make the key behaviors (letting keyboard users select block 10 in 10 keypresses, and employing parent-first selection for the mouse) intuitive enough, we can potentially make the dropdown invisible in distraction free. As is, however, neither of the main features of select mode are intuitive or obvious. To me the best part of select mode is the ability to press Esc then Del to delete an entire paragraph block, and that seems mostly a critique of how hard it is to delete blocks in general.

The main problem IMO is that select mode reserves the Esc key for invokation, which is such a high value shortcut that we should use it for deselect. I'd love to find a different keyboard shortcut for it — maybe holding down ⌘? If we did this, it might also solve both #48904 and #47172.

@talldan talldan added the [Feature] Distraction Free A preference in the Post and Site Editor that limits distractions to focus the editing experience label Jun 19, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Jul 26, 2023
@draganescu
Copy link
Contributor

Distraction free mode should be allowed in any interaction model I think. It's in the name you can write distraction free or you can design distraction free. On the other hand I am not sure about the toggle itself. Maybe switching interaction models should only work through the command palette in DFM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Distraction Free A preference in the Post and Site Editor that limits distractions to focus the editing experience Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants