Bug: duplicate key when using QueryControls with categorySuggestions

[hastinbe]

There are 2 separate but related issues here.

QueryControls component

The category name is used when defining the key, because those are not unique when you have multiple categories with the same name you'll get duplicate keys and UI side effects where you cannot remove the duplicate tokens in the Editor.

For reference:

gutenberg/packages/components/src/query-controls/index.tsx

Line 157 in f70ecc5

value: item.name || item.value,

gutenberg/packages/components/src/form-token-field/index.tsx

Line 599 in f70ecc5

<FlexItem key={ 'token-' + _value }>

Latest Posts block

This also affects the Latest Posts component in a couple ways. The first is not directly related to the above problem, but it is unable to display categories with the same names as suggestions because it too uses the non-unique name as seen here:

gutenberg/packages/block-library/src/latest-posts/edit.js

Line 172 in f70ecc5

[ category.name ]: category,

To reproduce:

• Create 2 categories with the same name.
• Start a new page in the editor and add the Latests Posts block
• Try to select your categories with the same name, only 1 will display as a suggestion

[mrfoxtalbot]

Thank you for reporting this @hastinbe. Could you please confirm if this bug was introduced with the latest 6.2 release or is this something you noticed before the update?

Also, could you please share more details on how you go about creating two terms with the same name in the first place? I tried this and neither the editor nor wp-admin/edit-tags.php will let me create a term with a duplicated name for a given taxonomy.

Thank you!

[hastinbe]

Sure, all you need to do is set a parent for the term. Sorry I should have explained that in the reproduce section of my post. I'm almost sure it happened before 6.2 as I recall upgrading to 6.2 after encountering the issue