Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching from text to heading only preserves first paragraph #496

Closed
ellatrix opened this issue Apr 24, 2017 · 4 comments
Closed

Switching from text to heading only preserves first paragraph #496

ellatrix opened this issue Apr 24, 2017 · 4 comments
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended

Comments

@ellatrix
Copy link
Member

To reproduce, transform a text block of min. 2 paragraphs into a heading. Only the first line is transformed into a heading, while the others disappear.
@ellatrix ellatrix added Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Bug An existing feature does not function as intended labels Apr 24, 2017
@youknowriad
Copy link
Contributor

Related discussions in #484 and #465.

@nylen
Copy link
Member

nylen commented Apr 26, 2017

+1 to fixing this, it violates the principle of least surprise. I think one of two things should happen instead:

  • Switching a multi-paragraph text block to a heading is disabled - this operation doesn't really make sense.
  • The current paragraph only is transformed into a heading, and the block is split into either two or three blocks. If we keep a text block as containing multiple paragraphs, it seems potentially difficult to surface this function in the UI.

@mtias mtias added the [Priority] High Used to indicate top priority items that need quick attention label Apr 28, 2017
@jasmussen
Copy link
Contributor

@youknowriad I think you fixed this? I can't seem to reproduce in master.

@youknowriad
Copy link
Contributor

Yep, this is fixed now. Let's close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nylen @youknowriad @mtias @jasmussen @ellatrix