-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual indication missing when transforming a block #50022
Comments
I don't think it's necessary in most cases to fire a snackbar between transforms—as you do get visual confirmation typically—but one image to gallery transform is a bit odd. |
It’s odd that the snack bar isn’t fired you mean? |
I don't think they're related. I'm not positive that this transform instance—from image to gallery—justifies adding snackbars for every transform (when nearly every other transform is visually represented), but I'm interested in what others (@WordPress/gutenberg-design) think. And I do certainly appreciate the sentiment + bringing up the issue. |
Is there any reason why transforming an Image to a Gallery deselects the original image? With other transforms the block seems to remain selected. If we did that here there would be some visual indication as the toolbar would change. |
It feels like this is really the root of the issue here. Keeping the image block selected would already help a lot! |
Yea, that seems to be the root issue here. @hanneslsm do you mind opening a separate issue with a screen recording of the transform between Image and Gallery, then another showing the transform selection working properly for Image -> Cover? |
Sure! #50308 |
Fixed via #50363 |
Description
There is not really a visual indication (notification / Snack Bar) when transforming a block.
Especially when transforming a image block to a gallery, a notification would improve the UX dramatically.
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
As you can see, it's difficult to see what's going on here. (Transforming an image block to a gallery, undo, doing it again, undo…)
Screen.Recording.2023-04-23.at.22.23.05.mp4
Environment info
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: