Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual indication missing when transforming a block #50022

Closed
hanneslsm opened this issue Apr 23, 2023 · 8 comments
Closed

Visual indication missing when transforming a block #50022

hanneslsm opened this issue Apr 23, 2023 · 8 comments
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.

Comments

@hanneslsm
Copy link

Description

There is not really a visual indication (notification / Snack Bar) when transforming a block.
Especially when transforming a image block to a gallery, a notification would improve the UX dramatically.

Step-by-step reproduction instructions

  1. Transform a block
  2. Wonder what happed. A notification does not appear.

Screenshots, screen recording, code snippet

As you can see, it's difficult to see what's going on here. (Transforming an image block to a gallery, undo, doing it again, undo…)

Screen.Recording.2023-04-23.at.22.23.05.mp4

Environment info

  • Wordpress 16.2

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@Thelmachido Thelmachido added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Blocks Overall functionality of blocks labels Apr 25, 2023
@richtabor
Copy link
Member

I don't think it's necessary in most cases to fire a snackbar between transforms—as you do get visual confirmation typically—but one image to gallery transform is a bit odd.

@hanneslsm
Copy link
Author

hanneslsm commented Apr 28, 2023

but one image to gallery transform is a bit odd.

It’s odd that the snack bar isn’t fired you mean?
The fact that a visual representation is missing is probably also because of #50021
The snack bar would be a quick fix here, but I’d vote for implementing it nonetheless until a solution for the other issue would make it irrelevant.

@richtabor
Copy link
Member

The fact that a visual representation is missing is probably also because of #50021

I don't think they're related.

I'm not positive that this transform instance—from image to gallery—justifies adding snackbars for every transform (when nearly every other transform is visually represented), but I'm interested in what others (@WordPress/gutenberg-design) think. And I do certainly appreciate the sentiment + bringing up the issue.

@jameskoster
Copy link
Contributor

Is there any reason why transforming an Image to a Gallery deselects the original image? With other transforms the block seems to remain selected. If we did that here there would be some visual indication as the toolbar would change.

@hanneslsm
Copy link
Author

Is there any reason why transforming an Image to a Gallery deselects the original image? With other transforms the block seems to remain selected. If we did that here there would be some visual indication as the toolbar would change.

It feels like this is really the root of the issue here. Keeping the image block selected would already help a lot!

@richtabor
Copy link
Member

richtabor commented Apr 30, 2023

Is there any reason why transforming an Image to a Gallery deselects the original image? With other transforms the block seems to remain selected.

Yea, that seems to be the root issue here. @hanneslsm do you mind opening a separate issue with a screen recording of the transform between Image and Gallery, then another showing the transform selection working properly for Image -> Cover?

@richtabor richtabor added [Block] Image Affects the Image Block and removed [Block] Image Affects the Image Block labels Apr 30, 2023
@hanneslsm
Copy link
Author

@hanneslsm do you mind opening a separate issue with a screen recording of the transform between Image and Gallery, then another showing the transform selection working properly for Image -> Cover?

Sure! #50308

@hanneslsm
Copy link
Author

Fixed via #50363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants