Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design → Templates → Manage all: Improve the table list view #50430

Closed
jasmussen opened this issue May 8, 2023 · 7 comments
Closed

Design → Templates → Manage all: Improve the table list view #50430

jasmussen opened this issue May 8, 2023 · 7 comments
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@jasmussen
Copy link
Contributor

In the site editor, both Templates and Template Parts have a drilldown section, "Manage all..." It's a little basic in terms of tools at the moment:

Image

Let's refine and improve this for clarity and legibility. A few things come to mind:

  • Consider template filters in the detail panel on the left
  • Fix the issue with the frame box shadow which is currently awkwardly cut off. It appears there's a missing white background color behind the frame.
  • Consider a creation date column, status, origin and other properties, considering templates will eventually be detached from the main theme. (Related: Remove coupling of templates, parts, and patterns when switching themes #25071)
  • Consider adding a search field.

Mainly, let's advance the section in general and use it as a template for similar list views.

@jasmussen jasmussen added the Needs Design Needs design efforts. label May 8, 2023
@jasmussen
Copy link
Contributor Author

Extracting a design from an adjacent exploration related to content editing; the list view patterns can nevertheless still be applied here:
Screenshot 2023-05-08 at 15 45 25

CC: @WordPress/gutenberg-design

@jasmussen
Copy link
Contributor Author

#48970 may have caused the issue with the missing white background near the "Add new" button, but we might still want to revisit that top area nad the general spacing.

@richtabor
Copy link
Member

#48970 may have caused the issue with the missing white background near the "Add new" button, but we might still want to revisit that top area nad the general spacing.

#50374 looks to resolve this. I’ll take a look today.

@SaxonF
Copy link
Contributor

SaxonF commented May 18, 2023

FYI I've started implementing a more generic Page component along with FilterBar and Table we can use for this issue (Templates and Template Parts) and #50028. I've bundled TanStack Table in just to play with it but probably don't need the complexity just yet. It's on branch try/table-view. Will hopefully have something more complete to post here tomorrow.

@jordesign jordesign added [Type] Enhancement A suggestion for improvement. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jul 19, 2023
@jasmussen
Copy link
Contributor Author

@jameskoster Can I close this issue in favor of #53233?

@jameskoster
Copy link
Contributor

@jasmussen I'd be inclined to leave both open for now. 53233 is about the full scope of the table component(s) we need to design/build, but we'll still need to choose exactly which elements of that to bring to this context.

@youknowriad
Copy link
Contributor

I think it's probably time to close these big data view issues for now. We should have more concrete smaller issues now. Let me know if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
Status: Needs dev
Development

No branches or pull requests

7 participants