Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concerns with post template markup being ul > li #50627

Open
chiilog opened this issue May 15, 2023 · 3 comments · May be fixed by #50694
Open

Concerns with post template markup being ul > li #50627

chiilog opened this issue May 15, 2023 · 3 comments · May be fixed by #50694
Assignees
Labels
[Block] Query Loop Affects the Query Loop Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@chiilog
Copy link
Contributor

chiilog commented May 15, 2023

What problem does this address?

What is your proposed solution?

Change ul and li to div.

@aristath
Copy link
Member

Hello @chiilog

I'm afraid I don't quite understand what post-template you're referring to...
Are you referring to the template for an archive of posts, where we have a list of posts? Or are you talking about a template for a single post? 🤔

@skorasaurus skorasaurus added the [Status] Needs More Info Follow-up required in order to be actionable. label May 15, 2023
@chiilog
Copy link
Contributor Author

chiilog commented May 16, 2023

@aristath
Sorry for the lack of info.
I checked with the template for an archive of posts.

For example, I use the Post Content in index template.

20230516091959

You can see that the top of the list is nested.
The sample uses twentytwentythree, but it will be reproduced using any theme.

@ndiego ndiego added Needs Testing Needs further testing to be confirmed. and removed [Status] Needs More Info Follow-up required in order to be actionable. labels May 16, 2023
@ndiego
Copy link
Member

ndiego commented May 16, 2023

We were able to confirm this in today's Editor Bug Scrub. The reason this occurs is because the Query Loop block uses an unordered list itself, and then any list in Post Content acts as a nested list, which receives the following CSS:

image

This is somewhat related to #37659. If you could change the element from a ul to perhaps a div via a selector, it would solve the issue. I imagine this would operate much like the selector in the Group block. 🤔

@ndiego ndiego added [Type] Bug An existing feature does not function as intended [Block] Query Loop Affects the Query Loop Block and removed Needs Testing Needs further testing to be confirmed. labels May 16, 2023
@torounit torounit linked a pull request May 17, 2023 that will close this issue
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants