Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking inside a block the block setting should automatically be seen. #5064

Closed
paaljoachim opened this issue Feb 15, 2018 · 7 comments
Closed
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Feb 15, 2018

I am testing version 2.1

Clicking inside a block in the preview area the right hand side block setting should automatically be seen.If the right side Document setting is selected it will also stay selected even when clicking or adding a block. As a block is added or clicked into the block setting should be seen so the user can see what can be done inside the block setting in relation to the block being used.

When the user needs to adjust something in the document setting the user can then click the document setting tab and switch over to it.

Bottom line: Relationships between what is being done and the settings/options in relation to it. Working on the document then document settings can be seen. Working on individual blocks then block settings can be seen. Just click the other tab to switch over.

screen shot 2018-02-15 at 00 17 23

@karmatosed
Copy link
Member

This has been gone through before and was ultimately decided to work way it does. That said, I still think it's worth considering what if the sidebar is closed. In that case I think that having it not show makes sense. If it is open then going straight to block settings does make sense. These were my feelings before and stand regarding this.

@mtias
Copy link
Member

mtias commented Feb 17, 2018

Yes, this was implemented in #819 a long time ago, then changed in #1833 as the general user feedback was it was confusing to have mode switch to the block whenever you selected a block. It could be revisited as the sidebar patterns are more settled.

@mtias mtias added the Needs Design Feedback Needs general design feedback. label Feb 17, 2018
@mtias
Copy link
Member

mtias commented Mar 6, 2018

@jasmussen what do you think of revisiting this?

@jasmussen
Copy link
Contributor

As you know, I love this idea, so much so that it was a core value of the initial inspector design (and the breadcrumb tree style in the top tab).

The reason we reverted was because of pushback.

I don't know if the tabs change anything, with regards to the pushback — if the Block tab was auto-selected when focusing a block and the sidebar was open, presumably clicking the Document tab would deselect the block, just like the breadcrumb trail did.

Or is there a nuance we can explore here?

CC: @folletto in case he has any ideas.

@karmatosed
Copy link
Member

I would still wave the +1 flag to bringing this back :) 🚩

I don't know if the tabs change anything, with regards to the pushback — if the Block tab was auto-selected when focusing a block and the sidebar was open, presumably clicking the Document tab would deselect the block, just like the breadcrumb trail did.

I would +1 to only selecting the blocks tab, this to me is the right nuance. I also think clicking Document should deselect as you are moving out of the flow.

@karmatosed karmatosed added the [Type] Enhancement A suggestion for improvement. label Mar 6, 2018
@karmatosed karmatosed added this to the Merge Proposal milestone Mar 6, 2018
@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Mar 6, 2018
@folletto
Copy link
Contributor

folletto commented Mar 7, 2018

The reason we reverted was because of pushback.

My take would be that 10 Jul 2017 was too early to see the benefit of the blocks sidebar getting focus when a block was selected: I might be entirely mistaken, but at that time a lot of block sidebars were still empty or with the same content of the toolbar.

I think now there's enough richness to show that the having full interaction consistency — when manipulating an object the sidebar should be showing that object inspector — also has direct, solid benefits.

I'd +1 too the nuance of behaviour expressed by @jasmussen above. Same thing, said in a different way:

  • Sidebar closed = selecting doesn't do anything on it
  • Sidebar opened + No block selected = Document sidebar active
  • Sidebar opened + Block selected = Block sidebar active
  • Explicitly clicking on Document = De-selects the block

Sounds good to me.

@mtias mtias modified the milestones: Merge Proposal, WordPress 5.0 Mar 7, 2018
@mtias
Copy link
Member

mtias commented Jun 22, 2018

This has been added back.

@mtias mtias closed this as completed Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants