Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize style inheritance #50659

Closed
jasmussen opened this issue May 16, 2023 · 1 comment
Closed

Visualize style inheritance #50659

jasmussen opened this issue May 16, 2023 · 1 comment
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json

Comments

@jasmussen
Copy link
Contributor

The style hierarchy and the style inheritance it allows can be hard to understand, as it is not surfaced in any way in the editor.

Image

In most cases understanding this style hierarchy is not crucial, as you can accomplish most of what you need to without the visualization. You go to global styles to style site wide, you edit pages to style locally. Nevertheless for more complex sessions, it can be useful to surface, but due to the rarity of needing to surface this, the footprint and UI weight of any visualization feature needs to be small.

Here's a take that makes the design tool label clickable to reveal the inheritance:

Image

  • Click a label to see the inheritance
  • If the popover has a link, that link should serve as a deep-link to the origin of the inheritance

For this concept to work, the Color flyout has received its own label.

Thoughts?

@jasmussen jasmussen converted this from a draft issue May 16, 2023
@jasmussen jasmussen moved this from Needs issue to Needs feedback in 6.3 Design May 16, 2023
@jasmussen jasmussen added Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json CSS Styling Related to editor and front end styles, CSS-specific issues. Needs Design Feedback Needs general design feedback. labels May 16, 2023
@jasmussen
Copy link
Contributor Author

Closing in favor of #49278.

@github-project-automation github-project-automation bot moved this from Needs feedback to Needs dev in 6.3 Design May 22, 2023
@jasmussen jasmussen moved this from Needs dev to Done in 6.3 Design May 22, 2023
@jasmussen jasmussen removed the Needs Design Feedback Needs general design feedback. label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
Projects
Status: Done
Development

No branches or pull requests

1 participant