-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LinkControl: Remove tools controls from initial state #50886
Comments
This suggestion feels right when yuo consider the UX as a whole as outlined in #50891. My only concern remains that this may make it difficult for users of assistive technology to dismiss the popover (we cannot rely on I'm not suggesting we retain
|
I'm fairly confident there's not a dedicated close action on any other popover, and I don't think LinkControl should be treated any differently. Also, ESC does work within the popovers throughout the editor — so I would think the convention would be realized. |
I do think it's good to keep Apply and Cancel actions within the context of editing a link #50890 — as it affords understanding to whether or not link changes have been saved, or discarded. |
Good to know we've considered this and accounted for the tradeoffs 👍 |
This was done as part of #51712 |
Part of #50891
The link settings, cancel, and apply "tools" (
block-editor-link-control__tools
) should only available when a link has been applied—not before. Let's remove these controls and have them only render if a link is added to the control.The text was updated successfully, but these errors were encountered: