Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the layout toggle #51172

Open
hanneslsm opened this issue Jun 1, 2023 · 3 comments
Open

Improving the layout toggle #51172

hanneslsm opened this issue Jun 1, 2023 · 3 comments
Labels
[Block] Group Affects the Group Block (and row, stack and grid variants) [Feature] Layout Layout block support, its UI controls, and style output. [Type] Copy Issues or PRs that need copy editing assistance

Comments

@hanneslsm
Copy link

hanneslsm commented Jun 1, 2023

What problem does this address?

Even though I am experienced with the Gutenberg editor, I am always getting confused by the Layout toggle, because the copy, description and order are not ideal.
image

  1. Full width → wide → content is how we perceive layouts. So, let's use this info as a mental model.

  2. "Inner blocks use content with" is very abstract. What does "using" mean? It implies that something is happening there? But they are set to a width, so they are static, right?
    I'm suggesting something like "Constrain width of inner blocks".
    Or even better, following basic UX copy rules for toggles, something like "Enable inner blocks width constraining" would be possible.

  3. Actually, using the mental model, it'd be good to include the Full Width. "Disable full width" could work, but is also not ideal for a toggle.

  4. Next, it's confusing that the "wide" input comes after the content input. I'd suggest switching both input fields.

The current mental model is something like Fullscreen NO / Constrain YES → Content → Wide which is … not ideal.

@annezazu Maybe this time a good issue for the UX & Polish board? ;). If this needs more discussion, how can these kind of issues get prioritised? This would easily increase the UX, the current implementation makes the editor so much harder to use.

@aurooba aurooba added [Type] Copy Issues or PRs that need copy editing assistance [Block] Group Affects the Group Block (and row, stack and grid variants) [Feature] Layout Layout block support, its UI controls, and style output. labels Jun 1, 2023
@annezazu
Copy link
Contributor

annezazu commented Jun 1, 2023

Thanks for opening! This matches the discussion here: #42385 and here #36082 Mind defaulting to those? This is far too big for the UX and Polish board as it touches on so many parts of the layout controls and that board is meant to be quickly actionable by devs.

@hanneslsm
Copy link
Author

hanneslsm commented Jun 1, 2023

This is far too big for the UX and Polish board

Yeah, I see what you mean. However, I fear it will take a while until a decision is made in the linked issues. Until then, we could just change the copy. Again, a good practise is using "Enable" or "Disable" for toggles.

@annezazu
Copy link
Contributor

annezazu commented Jun 1, 2023

I hear you. I have a ton of issues personally that I wanted to add to the board too! It's one effort to address items and we'll have more to come. Let's see what folks think around copy and how that can be iterated upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Group Affects the Group Block (and row, stack and grid variants) [Feature] Layout Layout block support, its UI controls, and style output. [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

No branches or pull requests

3 participants