Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles: consider increasing the prominence of revisions #51203

Closed
annezazu opened this issue Jun 2, 2023 · 5 comments
Closed

Styles: consider increasing the prominence of revisions #51203

annezazu opened this issue Jun 2, 2023 · 5 comments
Labels
[Feature] History History, undo, redo, revisions, autosave. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

annezazu commented Jun 2, 2023

Currently, revisions for style variations is placed behind the three dot menu in the sidebar:

Screen Shot 2023-06-02 at 9 08 10 AM

This places it at the same prominence as Custom CSS which intentionally was placed there to add friction to adding CSS, an action folks should have to take less and less as the Site Editor grows in functionality. In the twenty-third call for testing for the FSE Outreach Program, @paaljoachim notes how odd this feels:

Revisions is too hidden away and needs to become more visible directly in the Styles area. Looking at the Post editor. In the sidebar there is an revisions icon and next to it it shows the amount of revisions. What about something like that for the Styles area in the Editor?

I think we should consider surfacing this more, particularly if we keep style variations in place as a top level item in the Site View considering the current bugs with switching between style variations (#50924) and lack of UI for explaining style hierarchy (#49278). cc @WordPress/gutenberg-design

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Feature] History History, undo, redo, revisions, autosave. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Jun 2, 2023
@jasmussen
Copy link
Contributor

I think @jameskoster might have a later design for this, but it seems like surfacing revisions in site view is a good way to bring extra prominence to a more high level receded view:

Screenshot 2023-06-06 at 09 51 03

@jameskoster
Copy link
Contributor

Style revisions are now accessible from the Styles panel in Site View.

A similar treatment in Edit View seems reasonable.

@paaljoachim
Copy link
Contributor

Are we ready to add the "Needs dev" label here?

@jameskoster
Copy link
Contributor

I think we're missing a mockup. Perhaps we simply reuse the button from posts / pages / template parts, positioned at the bottom of the panel?

Screenshot 2023-06-08 at 09 59 38

This could work as a short-term solution, but it's beginning to feel like we need to take a broader look at the Styles panel in light of these new features (revisions, style book), and the advent of Site View.

@jordesign
Copy link
Contributor

Closing this as we now have the Style Revisions icon at the top level.

Screenshot 2024-01-12 at 11 02 29 am

Happy to re-open if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] History History, undo, redo, revisions, autosave. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants