Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Styles: Add support for elements to individual blocks #51272

Closed
scruffian opened this issue Jun 6, 2023 · 6 comments
Closed

Global Styles: Add support for elements to individual blocks #51272

scruffian opened this issue Jun 6, 2023 · 6 comments
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@scruffian
Copy link
Contributor

What problem does this address?

There is currently no way to edit element styles for individual blocks using the Global Styles UI. This makes it impossible to modify even some very basic design choices - for example: #51265.

What is your proposed solution?

We should add support for elements to block controls in Global Styles to make the UI more powerful.

@scruffian scruffian added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Jun 6, 2023
@nielslange
Copy link
Contributor

@scruffian Another use case can be found on woocommerce/woocommerce-blocks#10118, where @mikejolley was wondering if it's possible to apply Global Styles for <th> and <td> independent of each other. From @glendaviesnz, I understood that this is not possible, and he pointed me to this issue to mention the use case here.

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Jul 18, 2023
@scruffian
Copy link
Contributor Author

scruffian commented Jul 31, 2023

Another time when this came up was trying to remove text decoration from the Site Title block - you need to do it for the link element which isn't possible in the UI.

Similarly it would be very useful to be able to add text decoration to links in a Post Content block.

@SaxonF
Copy link
Contributor

SaxonF commented Sep 3, 2023

@scruffian does this PR resolve this issue or am I misunderstanding the problem?

@scruffian
Copy link
Contributor Author

No this issue is about making elements available in the Global Styles UI:

Screenshot 2023-09-04 at 16 06 42

these controls should also be available in the block controls for each block that supports it.

@SaxonF
Copy link
Contributor

SaxonF commented Sep 11, 2023

these controls should also be available in the block controls for each block that supports it.

@scruffian I still may be misunderstanding but on trunk I now see extended elements in blocks.

image

@scruffian
Copy link
Contributor Author

@SaxonF you're right this does appear in some places, but not everywhere we'd like it - for example there is no way to change captions for all image blocks. However I think that's better dealt with in a different issue, so let's close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
Development

No branches or pull requests

5 participants