Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Target Attributes #5147

Closed
richardkentgates opened this issue Feb 19, 2018 · 6 comments
Closed

Link Target Attributes #5147

richardkentgates opened this issue Feb 19, 2018 · 6 comments

Comments

@richardkentgates
Copy link

richardkentgates commented Feb 19, 2018

I noticed since beginning use of this plugin that the editor has no way to open links in new tab/window. Now at 2.2.0, manually entering the target attribute, it is completely removing the attribute in mid-typing. Once I get the attribute to target="" without any parameter/value, the editor removes it. I hope this is a glitch and not intentional. I haven't read anywhere that opening links in new tabs is bad for UX or anything else that justifies this. Whatever is making this happen needs to be removed from the project.

@Soean
Copy link
Member

Soean commented Feb 21, 2018

The open in new window option was removed in #4583

Which block type are you using to enter the link attribute manually? I was not able to recreate this bug.

@richardkentgates
Copy link
Author

I am using an up-to-date version of WordPress with the Gutenberg plugin. It happens when I use a paragraph block. I haven't tried to recreate this with any other blocks. I tried editing as code but that also results in the attribute being removed. The only way to have the target attribute is to use the classic editor.

@richardkentgates
Copy link
Author

I can understand not making this part of the WordPress platform, but editing it out when it's been manually placed is a bit of overreach.

@Soean
Copy link
Member

Soean commented Feb 21, 2018

Of course this should be possible.
I tested again on the paragraph block and I was able to add target="_blank" to a link.

@richardkentgates
Copy link
Author

richardkentgates commented Feb 21, 2018

Strange behavior. I'm not experiencing the problem now. The target attribute is working fine. What to do with this thread?

@Soean
Copy link
Member

Soean commented Feb 21, 2018

Maybe you had a small typo in the attribute, then it gets deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants